1540556 - Perma Linux DevEdition browser_windowopen.js | unexpected changed rect: ({x1:1241, x2:1241, y1:36, y2:69, w:1, h:34}), window width: 1280 when Gecko 68 merges to Beta on 2019-05-06

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Raul Gurzau (:RaulG)]

[Tracking Requested - why for this release]:

Central as Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=7d697d08b5569edf179d3f1d700a5506ace0cd01&selectedJob=237221040&searchStr=linux%2Cx64%2Cdevedition%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64-devedition%2Fopt-mochitest-browser-chrome-e10s-4%2Cm-e10s%28bc4%29

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237221040&repo=try&lineNumber=2572

Log snippet:
[task 2019-03-31T15:09:57.418Z] 15:09:57 INFO - TEST-FAIL | browser/base/content/test/performance/browser_windowopen.js | bug 1421463 - reload toolbar icon shouldn't flicker, ({x1:110, x2:124, y1:46, y2:59, w:15, h:14}), window width: 1280 -
[task 2019-03-31T15:09:57.419Z] 15:09:57 INFO - Buffered messages finished
[task 2019-03-31T15:09:57.420Z] 15:09:57 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen.js | unexpected changed rect: ({x1:1241, x2:1241, y1:36, y2:69, w:1, h:34}), window width: 1280 -
[task 2019-03-31T15:09:57.421Z] 15:09:57 INFO - Stack trace:
[task 2019-03-31T15:09:57.422Z] 15:09:57 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2019-03-31T15:09:57.422Z] 15:09:57 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:reportUnexpectedFlicker/rects<:578
[task 2019-03-31T15:09:57.423Z] 15:09:57 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:reportUnexpectedFlicker:569
[task 2019-03-31T15:09:57.424Z] 15:09:57 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:withPerfObserver:637

Comment 1

[Alex Thayer [:alexical] (she/her)]

Not too familiar with how this test is supposed to work but I think this is Toolbars and Customization.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: First frame

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Second frame

These are the two frames from the log reporting the flicker.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

It looks like what's being reported is a flicker for the separator between the appmenu button and the rest of the toolbar.

So I suspect this has more to do with the DevEdition theme than Toolbars and Customization.

Comment 5

[Dão Gottwald [:dao]]

I suspect this is from the recent LightWeightTheme -> webext theme conversion or related LightWeightThemeManager changes, e.g. bug 1525762.

Comment 6

[Kris Maglione [:kmag]]

Prior to bug 1525762, we always ran browser mochitests with the default theme, even in dev edition builds, so the issue is probably not new, only the fact that it shows up in test runs. Bug 1540856 restored the behavior of always running browser tests with the default theme.

Fixing the flicker, and/or whatever else may be causing this failure, would probably be a good idea, but is also probably a different bug.

Comment 7

[Cosmin Sabou [:CosminS]]

Verified fix in today's beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=5de631f349bb6f4c5461a825d4ffba4c54ae8f34&searchStr=linux%2Cx64%2Cdevedition%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64-devedition%2Fopt-mochitest-browser-chrome-e10s-4%2Cm-e10s%28bc4%29&selectedJob=238582381