Closed Bug 1540576 Opened 8 months ago Closed 8 months ago

Extending GetProgramBinary to GeckoView

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-amvp][wr-q2])

Attachments

(2 files)

This bug is created based on Bug 1535146 comment 13.

Blocks: 1535146
Blocks: wr-android
Assignee: nobody → sotaro.ikeda.g
No longer blocks: wr-android
Whiteboard: [wr-amvp][wr-q2]
Depends on: 1546901

Without shader binary disk cache, Device.link_program() took 60 ms - 200 ms for each shader program.

With shader binary disk cache, Device.link_program() took less than 1 ms, though loading from disk took 10 ms - 70 ms. Loading disk cache could be done before WebRender Renderer creation. There were about 200ms from WrProgramCache until the Renderer. The duration could be used for loading binary disk cache. With it, shader binary disk cache could improve start up performance.

Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1b40ea6176f
Enable Shader disk cache on Android r=nical

(In reply to Sotaro Ikeda [:sotaro away April/27 - May/6] from comment #1)

Without shader binary disk cache, Device.link_program() took 60 ms - 200 ms for each shader program.

With shader binary disk cache, Device.link_program() took less than 1 ms, though loading from disk took 10 ms - 70 ms.

Nice. In some cases this won't matter - e.g. when the app is launched with an empty intent and we land on the home screen. But when the app is launched with a URL, startup time will be a bottleneck.

Loading disk cache could be done before WebRender Renderer creation. There were about 200ms from WrProgramCache until the Renderer.

Neat - is there any more delay between startup and the current WrProgramCache initialization? If so we could move it even earlier.

The duration could be used for loading binary disk cache. With it, shader binary disk cache could improve start up performance.

That's a great idea - can you get a bug on file?

Flags: needinfo?(sotaro.ikeda.g)
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

(In reply to Bobby Holley (:bholley) from comment #5)

The duration could be used for loading binary disk cache. With it, shader binary disk cache could improve start up performance.

That's a great idea - can you get a bug on file?

Created Bug 1549927.

Flags: needinfo?(sotaro.ikeda.g)
You need to log in before you can comment on or make changes to this bug.