1540576 - Extending GetProgramBinary to GeckoView

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

This bug is created based on Bug 1535146 comment 13.

Comment 1

[Sotaro Ikeda [:sotaro]]

Without shader binary disk cache, Device.link_program() took 60 ms - 200 ms for each shader program.

With shader binary disk cache, Device.link_program() took less than 1 ms, though loading from disk took 10 ms - 70 ms. Loading disk cache could be done before WebRender Renderer creation. There were about 200ms from WrProgramCache until the Renderer. The duration could be used for loading binary disk cache. With it, shader binary disk cache could improve start up performance.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Enable Shader disk cache with log

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1540576 - Enable Shader disk cache on Android

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1b40ea6176f
Enable Shader disk cache on Android r=nical

Comment 5

[Bobby Holley (:bholley)]

(In reply to Sotaro Ikeda [:sotaro away April/27 - May/6] from comment #1)

Without shader binary disk cache, Device.link_program() took 60 ms - 200 ms for each shader program.

With shader binary disk cache, Device.link_program() took less than 1 ms, though loading from disk took 10 ms - 70 ms.

Nice. In some cases this won't matter - e.g. when the app is launched with an empty intent and we land on the home screen. But when the app is launched with a URL, startup time will be a bottleneck.

Loading disk cache could be done before WebRender Renderer creation. There were about 200ms from WrProgramCache until the Renderer.

Neat - is there any more delay between startup and the current WrProgramCache initialization? If so we could move it even earlier.

The duration could be used for loading binary disk cache. With it, shader binary disk cache could improve start up performance.

That's a great idea - can you get a bug on file?

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e1b40ea6176f

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to Bobby Holley (:bholley) from comment #5)

The duration could be used for loading binary disk cache. With it, shader binary disk cache could improve start up performance.

That's a great idea - can you get a bug on file?

Created Bug 1549927.