Closed Bug 1540581 Opened 3 years ago Closed 3 years ago

Rec601 colorspace always used for hardware decoded video

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 2 open bugs)

Details

Attachments

(19 files, 1 obsolete file)

Bug 1540581 - P1. Fix NV12 image with OGL compositor. r?mattwoodrow
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P2. Add missing VideoInfo members to IPC serializer. r?bryce
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P3. Add methods to extract color space and color depth from SPS NAL. r?bryce
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P4. Add ColorSpace/ColorDepth component to NV12 gfx::Effect. r?mattwoodrow
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P5. Add ColorSpace info to MacIOSurface. r?mattwoodrow
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r?gerald,mattwoodrow
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P7. Use Variant instead of Union/Enum. r?kats
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P8. Set decoding format back to NV12 and set colorspace. r?bryce
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P9. Add R16G16 type and update of P010/P016 resource update. r?mattwoodrow
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P10. Pass colorspace data with first VP9 frame seen. r?bryce
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P11. Handle colorspace correctly with D3D11 images. r?mattwoodrow,nical
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P12. Pass YUV colorspace information with WMF decoder. r?bryce,mattwoodrow.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P13. Properly handle colorspace with D3D11 compositors. r?mattwoodrow
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P15. Don't have base class methods return child ones. r?nical
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P16. Mark allocation helper class as RAII. r?nical
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P17. Remove DXGITextureData object. r?nical
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P18. Move destination texture type choice to the D3D11 texture allocator. r?mattwoodrow
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P19. Mark h264 streams as being BT601. r?bryce
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540581 - P20. Change fuzzying leeway on macOS. r?mattwoodrow
47 bytes, text/x-phabricator-request
Details | Review

When using HW decoder (either on mac or windows), the colorspace used is Rec601 regardless of what the video set.

Depends on: 1305510
Assignee: nobody → jyavenard
Rank: 15
Priority: -- → P2
Duplicate of this bug: 1536933

Another case where you have to wonder how did this ever worked!?

Depends on D26054

It would have been nicer and more logical to use a MacIOSurfaceImage to store the colorspace information, however the data passed around is a IOSurface Id via a SurfaceDescriptorMacIOSurface; the original data structure isn't kept; so we must transit the data at the same time as the IOSurface Id.

Also remove unnecessary test (new operator is infallible).

Depends on D26057

  • Remove redundant virtual keywords
  • Mark all destructors of inheriting classes as virtual for clarity
  • Mark all classes without virtual destructor as final (exposed errors)
  • Make distructor virtual where it needed to be (some were missing)
  • Replace empty ({}) code declaration in header with = default
  • Remove virtual unused methods

I probably missed some, it quickly became a rabbit hole.

Depends on D26058

It allows for use of default constructor/destructor and leaves no room to incorrectly modify the union members with a wrong type.

Depends on D26060

(In reply to Jean-Yves Avenard [:jya] from comment #9)

Created attachment 9055709 [details]
Bug 1540581 - P8. Set decoding format back to NV12 and set colorspace. r?bryce

Depends on D26061

Hello, does this mean the fix is already finished and contained in Nightly? Because I just downloaded Nightly and it displays the video correctly!

Thank you :)

Best regards
Michal

(In reply to Michal Zušťák from comment #10)

(In reply to Jean-Yves Avenard [:jya] from comment #9)

Created attachment 9055709 [details]
Bug 1540581 - P8. Set decoding format back to NV12 and set colorspace. r?bryce

Depends on D26061

Hello, does this mean the fix is already finished and contained in Nightly? Because I just downloaded Nightly and it displays the video correctly!

No, that change hasn't been pushed either.

Colors will be good only one machines with no HW accelerated decoding, so if VP9 you'll get good colours of you have an older video card.

(In reply to Jean-Yves Avenard [:jya] from comment #11)

(In reply to Michal Zušťák from comment #10)

(In reply to Jean-Yves Avenard [:jya] from comment #9)

Created attachment 9055709 [details]
Bug 1540581 - P8. Set decoding format back to NV12 and set colorspace. r?bryce

Depends on D26061

Hello, does this mean the fix is already finished and contained in Nightly? Because I just downloaded Nightly and it displays the video correctly!

No, that change hasn't been pushed either.

Colors will be good only one machines with no HW accelerated decoding, so if VP9 you'll get good colours of you have an older video card.

I have a GTX 1060 and it has the wrong color in regular Firefox but good ones in Nightly.

(In reply to Michal Zušťák from comment #12)

I have a GTX 1060 and it has the wrong color in regular Firefox but good ones in Nightly.

that can't be.

The HW decoder must be deactivated somehow.
Please post your about:support info on your nightly profile.

(In reply to Jean-Yves Avenard [:jya] from comment #13)

(In reply to Michal Zušťák from comment #12)

I have a GTX 1060 and it has the wrong color in regular Firefox but good ones in Nightly.

that can't be.

The HW decoder must be deactivated somehow.
Please post your about:support info on your nightly profile.

{
"application": {
"name": "Firefox",
"osVersion": "Windows_NT 10.0",
"version": "68.0a1",
"buildID": "20190404063228",
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0",
"safeMode": false,
"updateChannel": "nightly",
"supportURL": "https://support.mozilla.org/1/firefox/68.0a1/WINNT/sk/",
"numTotalWindows": 1,
"numRemoteWindows": 1,
"launcherProcessState": 0,
"remoteAutoStart": true,
"currentContentProcesses": 10,
"maxContentProcesses": 8,
"autoStartStatus": 1,
"policiesStatus": 0,
"keyLocationServiceGoogleFound": true,
"keySafebrowsingGoogleFound": true,
"keyMozillaFound": true
},
"securitySoftware": {
"registeredAntiVirus": "Avast Antivirus",
"registeredAntiSpyware": "Avast Antivirus",
"registeredFirewall": "Avast Antivirus"
},
"modifiedPreferences": {
"accessibility.typeaheadfind.flashBar": 0,
"browser.cache.disk.capacity": 1048576,
"browser.cache.disk.filesystem_reported": 1,
"browser.sessionstore.upgradeBackup.latestBuildID": "20190404063228",
"browser.startup.homepage_override.buildID": "20190404063228",
"browser.startup.homepage_override.mstone": "68.0a1",
"browser.tabs.warnOnClose": false,
"browser.urlbar.placeholderName": "Google",
"browser.urlbar.timesBeforeHidingSuggestionsHint": 0,
"dom.forms.autocomplete.formautofill": true,
"dom.push.userAgentID": "c9041b8920aa4b159cf0fabae7de53f8",
"extensions.lastAppVersion": "68.0a1",
"gfx.crash-guard.status.wmfvpxvideo": 3,
"gfx.crash-guard.wmfvpxvideo.appVersion": "68.0a1",
"gfx.crash-guard.wmfvpxvideo.deviceID": "0x1c03",
"gfx.crash-guard.wmfvpxvideo.driverVersion": "25.21.14.1967",
"gfx.webrender.all": true,
"idle.lastDailyNotification": 1554395684,
"layers.mlgpu.sanity-test-failed": false,
"media.gmp-manager.lastCheck": 1554495466,
"media.benchmark.vp9.fps": 290,
"media.benchmark.vp9.versioncheck": 5,
"media.gmp-gmpopenh264.abi": "x86_64-msvc-x64",
"media.gmp-gmpopenh264.lastUpdate": 1552948642,
"media.gmp-gmpopenh264.version": "1.8.1",
"media.gmp-manager.buildID": "20190404063228",
"media.gmp-widevinecdm.abi": "x86_64-msvc-x64",
"media.gmp-widevinecdm.lastUpdate": 1552948650,
"media.gmp-widevinecdm.version": "4.10.1146.0",
"media.gmp.storage.version.observed": 1,
"media.hardware-video-decoding.failed": false,
"network.dns.disablePrefetch": true,
"network.http.speculative-parallel-limit": 0,
"network.predictor.cleaned-up": true,
"network.predictor.enabled": false,
"network.prefetch-next": false,
"places.database.lastMaintenance": 1554395684,
"places.history.expiration.transient_current_max_pages": 112348,
"plugin.disable_full_page_plugin_for_types": "application/pdf",
"privacy.sanitize.pending": "[{"id":"newtab-container","itemsToClear":[],"options":{}}]",
"privacy.cpd.offlineApps": true,
"privacy.cpd.siteSettings": true,
"privacy.sanitize.timeSpan": 0,
"security.remote_settings.intermediates.checked": 1554495381,
"security.sandbox.content.tempDirSuffix": "{23e8f32c-1486-4efe-a222-4cf25500a304}",
"security.sandbox.plugin.tempDirSuffix": "{7b1474ac-170f-4ad0-953f-5ff0d3b655cf}",
"services.sync.declinedEngines": "",
"services.sync.engine.addresses.available": true,
"signon.importedFromSqlite": true,
"storage.vacuum.last.index": 1,
"storage.vacuum.last.places.sqlite": 1553780142,
"ui.osk.debug.keyboardDisplayReason": "IKPOS: Touch screen not found."
},
"lockedPreferences": {},
"media": {
"currentAudioBackend": "wasapi",
"currentMaxAudioChannels": 2,
"currentPreferredSampleRate": 44100,
"audioOutputDevices": [
{
"name": "Digital Audio (HDMI) (High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 2,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "NVIDIA Output (NVIDIA High Definition Audio)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 2,
"state": 1,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Digital Audio (HDMI) (High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 2,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Digital Audio (HDMI) (High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 2,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Internal AUX Jack (2- High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_18494893&REV_1003\5&46773b4&0&0001",
"vendor": "",
"type": 2,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "VX279 (High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 2,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 2,
"defaultRate": 44100,
"maxRate": 44100,
"minRate": 44100,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Internal AUX Jack (2- High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_18494893&REV_1003\5&46773b4&0&0001",
"vendor": "",
"type": 2,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "NVIDIA Output (NVIDIA High Definition Audio)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 2,
"state": 1,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Headphones (2- High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_18494893&REV_1003\5&46773b4&0&0001",
"vendor": "",
"type": 2,
"state": 2,
"preferred": 7,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 2,
"defaultRate": 44100,
"maxRate": 44100,
"minRate": 44100,
"maxLatency": 448,
"minLatency": 129
},
{
"name": "NVIDIA Output (NVIDIA High Definition Audio)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 2,
"state": 1,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "VX279 (NVIDIA High Definition Audio)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 2,
"state": 2,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 2,
"defaultRate": 48000,
"maxRate": 48000,
"minRate": 48000,
"maxLatency": 480,
"minLatency": 144
}
],
"audioInputDevices": [
{
"name": "Internal AUX Jack (High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 1,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Internal AUX Jack (NVIDIA High Definition Audio)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 1,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Microphone (Microsoft® LifeCam VX-2000)",
"groupId": "USB\VID_045E&PID_0761&MI_02\7&1521060c&0&0002",
"vendor": "",
"type": 1,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 1,
"defaultRate": 44100,
"maxRate": 44100,
"minRate": 44100,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Internal AUX Jack (NVIDIA High Definition Audio)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 1,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Microphone (2- Microsoft® LifeCam VX-2000)",
"groupId": "USB\VID_045E&PID_0761&MI_02\7&38a85474&0&0002",
"vendor": "",
"type": 1,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 1,
"defaultRate": 44100,
"maxRate": 44100,
"minRate": 44100,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Microphone (2- High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_18494893&REV_1003\5&46773b4&0&0001",
"vendor": "",
"type": 1,
"state": 1,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Internal AUX Jack (NVIDIA High Definition Audio)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 1,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Internal AUX Jack (High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 1,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Line In (2- High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_18494893&REV_1003\5&46773b4&0&0001",
"vendor": "",
"type": 1,
"state": 1,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Microphone (2- High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_18494893&REV_1003\5&46773b4&0&0001",
"vendor": "",
"type": 1,
"state": 1,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
},
{
"name": "Internal AUX Jack (High Definition Audio Device)",
"groupId": "HDAUDIO\FUNC_01&VEN_10DE&DEV_0084&SUBSYS_14623283&REV_1001\5&5d266dd&0&0001",
"vendor": "",
"type": 1,
"state": 0,
"preferred": 0,
"supportedFormat": 4112,
"defaultFormat": 4096,
"maxChannels": 0,
"defaultRate": 0,
"maxRate": 0,
"minRate": 0,
"maxLatency": 0,
"minLatency": 0
}
]
},
"javaScript": {
"incrementalGCEnabled": true
},
"accessibility": {
"isActive": false,
"forceDisabled": 0,
"handlerUsed": true,
"instantiator": ""
},
"libraryVersions": {
"NSPR": {
"minVersion": "4.21",
"version": "4.21"
},
"NSS": {
"minVersion": "3.44 Beta",
"version": "3.44 Beta"
},
"NSSUTIL": {
"minVersion": "3.44 Beta",
"version": "3.44 Beta"
},
"NSSSSL": {
"minVersion": "3.44 Beta",
"version": "3.44 Beta"
},
"NSSSMIME": {
"minVersion": "3.44 Beta",
"version": "3.44 Beta"
}
},
"userJS": {
"exists": false
},
"intl": {
"localeService": {
"requested": [
"sk"
],
"available": [
"sk",
"en-US"
],
"supported": [
"sk",
"en-US"
],
"regionalPrefs": [
"sk-SK"
],
"defaultLocale": "sk"
},
"osPrefs": {
"systemLocales": [
"sk-SK"
],
"regionalPrefsLocales": [
"sk-SK"
]
}
},
"crashes": {
"submitted": [
{
"id": "bp-a7ce39f7-e723-49fc-8d0e-be6430190404",
"date": 1554411864880,
"pending": false
},
{
"id": "bp-de5e37cc-9f75-4059-b6ed-1f00c0190404",
"date": 1554404838031,
"pending": false
},
{
"id": "bp-046b42d4-7857-4308-beec-125b30190404",
"date": 1554401422357,
"pending": false
},
{
"id": "bp-579e8a1b-7656-4024-a2ce-2e3e70190404",
"date": 1554398286796,
"pending": false
},
{
"id": "bp-92fef35a-6c3d-4903-b861-847340190404",
"date": 1554398279312,
"pending": false
}
],
"pending": 0
},
"sandbox": {
"contentSandboxLevel": 5,
"effectiveContentSandboxLevel": 5
},
"graphics": {
"numTotalWindows": 1,
"numAcceleratedWindows": 1,
"windowLayerManagerType": "WebRender",
"windowLayerManagerRemote": true,
"windowUsingAdvancedLayers": false,
"adapterDescription": "NVIDIA GeForce GTX 1060 6GB",
"adapterVendorID": "0x10de",
"adapterDeviceID": "0x1c03",
"adapterSubsysID": "32831462",
"adapterRAM": "6144",
"adapterDrivers": "C:\Windows\System32\DriverStore\FileRepository\nvmdi.inf_amd64_2c15caefab34b384\nvldumdx.dll,C:\Windows\System32\DriverStore\FileRepository\nvmdi.inf_amd64_2c15caefab34b384\nvldumdx.dll,C:\Windows\System32\DriverStore\FileRepository\nvmdi.inf_amd64_2c15caefab34b384\nvldumdx.dll,C:\Windows\System32\DriverStore\FileRepository\nvmdi.inf_amd64_2c15caefab34b384\nvldumdx.dll C:\Windows\System32\DriverStore\FileRepository\nvmdi.inf_amd64_2c15caefab34b384\nvldumd.dll,C:\Windows\System32\DriverStore\FileRepository\nvmdi.inf_amd64_2c15caefab34b384\nvldumd.dll,C:\Windows\System32\DriverStore\FileRepository\nvmdi.inf_amd64_2c15caefab34b384\nvldumd.dll,C:\Windows\System32\DriverStore\FileRepository\nvmdi.inf_amd64_2c15caefab34b384\nvldumd.dll",
"driverVersion": "25.21.14.1967",
"driverDate": "3-17-2019",
"adapterDescription2": "",
"adapterVendorID2": "",
"adapterDeviceID2": "",
"adapterSubsysID2": "",
"adapterRAM2": "",
"adapterDrivers2": "",
"driverVersion2": "",
"driverDate2": "",
"isGPU2Active": false,
"direct2DEnabled": true,
"directWriteEnabled": true,
"directWriteVersion": "10.0.17763.168",
"clearTypeParameters": "Gamma: 1,8 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50 ",
"usesTiling": false,
"contentUsesTiling": true,
"offMainThreadPaintEnabled": true,
"offMainThreadPaintWorkerCount": 4,
"targetFrameRate": 60,
"webgl1Renderer": "Google Inc. -- ANGLE (NVIDIA GeForce GTX 1060 6GB Direct3D11 vs_5_0 ps_5_0)",
"webgl1Version": "OpenGL ES 2.0 (ANGLE 2.1.0.eff6bfdb1db9)",
"webgl1DriverExtensions": "GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_KHR_parallel_shader_compile GL_KHR_robust_buffer_access_behavior GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture ",
"webgl1Extensions": "ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_disjoint_timer_query EXT_float_blend EXT_frag_depth EXT_shader_texture_lod EXT_sRGB EXT_texture_filter_anisotropic OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context",
"webgl1WSIInfo": "EGL_VENDOR: Google Inc. (adapter LUID: 000000000000af36)\nEGL_VERSION: 1.4 (ANGLE 2.1.0.eff6bfdb1db9)\nEGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled EGL_MOZ_create_context_provoking_vertex_dont_care \nEGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_KHR_debug EGL_ANGLE_explicit_context ",
"webgl2Renderer": "Google Inc. -- ANGLE (NVIDIA GeForce GTX 1060 6GB Direct3D11 vs_5_0 ps_5_0)",
"webgl2Version": "OpenGL ES 3.0 (ANGLE 2.1.0.eff6bfdb1db9)",
"webgl2DriverExtensions": "GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_multiview GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_KHR_parallel_shader_compile GL_KHR_robust_buffer_access_behavior GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture ",
"webgl2Extensions": "EXT_color_buffer_float EXT_disjoint_timer_query EXT_float_blend EXT_texture_filter_anisotropic OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context",
"webgl2WSIInfo": "EGL_VENDOR: Google Inc. (adapter LUID: 000000000000af36)\nEGL_VERSION: 1.4 (ANGLE 2.1.0.eff6bfdb1db9)\nEGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled EGL_MOZ_create_context_provoking_vertex_dont_care \nEGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_KHR_debug EGL_ANGLE_explicit_context ",
"info": {
"AzureCanvasBackend (UI Process)": "skia",
"AzureFallbackCanvasBackend (UI Process)": "cairo",
"AzureContentBackend (UI Process)": "skia",
"AzureCanvasBackend": "direct2d 1.1",
"AzureContentBackend": "skia",
"ApzWheelInput": 1,
"ApzDragInput": 1,
"ApzKeyboardInput": 1,
"ApzAutoscrollInput": 1,
"Slow Frame #01": "Frame 1238(https://en.wikipedia.org/wiki/Digital_subscriber_line#History) CONTENT_FRAME_TIME 666307 - Transaction start 0,000000, main-thread time 3,332700, full paint time 4,438800, Skipped composites 0, Composite start 15,640900, Resource upload time 0,113800, GPU cache upload time 0,044700, Render time 1,202600, Composite time 1,938900",
"Slow Frame #02": "Frame 2152(https://www.reddit.com/r/nostalgiaEurope/?count=25&after=t3_b8xmem) CONTENT_FRAME_TIME 442914 - Transaction start 0,000000, main-thread time 2,862500, full paint time 3,772800, Skipped composites 0, Composite start 3,940200, Resource upload time 0,000700, GPU cache upload time 0,054500, Render time 1,300000, Composite time 1,970800",
"Slow Frame #03": "Frame 500(https://uloz.to/!fA6cJuSs/korn-2005-see-you-on-the-other-side-rar) CONTENT_FRAME_TIME 394810 - Transaction start 0,000000, main-thread time 2,597800, full paint time 3,799400, Skipped composites 0, Composite start 12,287100, Resource upload time 0,000600, GPU cache upload time 0,031300, Render time 1,257200, Composite time 2,238700",
"Slow Frame #04": "Frame 516(https://en.wikipedia.org/wiki/Teletext#Data_transmission) CONTENT_FRAME_TIME 237012 - Transaction start 0,000000, main-thread time 1,723000, full paint time 2,864000, Skipped composites 0, Composite start 10,692200, Resource upload time 0,000500, GPU cache upload time 0,053100, Render time 1,067100, Composite time 1,789700",
"Slow Frame #05": "Frame 160(https://en.wikipedia.org/wiki/Microwave_transmission) CONTENT_FRAME_TIME 226919 - Transaction start 0,000000, main-thread time 2,075200, full paint time 2,967300, Skipped composites 0, Composite start 9,895100, Resource upload time 0,002500, GPU cache upload time 0,068100, Render time 1,498500, Composite time 2,961000",
"Slow Frame #06": "Frame 724(https://en.wikipedia.org/wiki/List_of_interface_bit_rates#Teletypewriter_(TTY)_or_telecommunications_device_for_the_deaf_(TDD)) CONTENT_FRAME_TIME 216715 - Transaction start 0,000000, main-thread time 2,403900, full paint time 3,300000, Skipped composites 0, Composite start 15,569000, Resource upload time 0,044600, GPU cache upload time 0,061500, Render time 1,203200, Composite time 2,188600",
"Slow Frame #07": "Frame 537(https://en.wikipedia.org/wiki/Teletext#Data_transmission) CONTENT_FRAME_TIME 196714 - Transaction start 0,000000, main-thread time 2,008300, full paint time 3,078300, Skipped composites 0, Composite start 3,082600, Resource upload time 0,027100, GPU cache upload time 0,060200, Render time 0,968500, Composite time 1,942100",
"Slow Frame #08": "Frame 533(https://en.wikipedia.org/wiki/Teletext#Data_transmission) CONTENT_FRAME_TIME 184110 - Transaction start 0,000000, main-thread time 1,922100, full paint time 2,647400, Skipped composites 0, Composite start 7,340300, Resource upload time 0,000500, GPU cache upload time 0,071200, Render time 1,089700, Composite time 1,760000",
"Slow Frame #09": "Frame 523(https://en.wikipedia.org/wiki/Teletext#Data_transmission) CONTENT_FRAME_TIME 153820 - Transaction start 0,000000, main-thread time 2,071300, full paint time 3,403100, Skipped composites 0, Composite start 17,973800, Resource upload time 0,384200, GPU cache upload time 0,438000, Render time 1,949900, Composite time 2,809700",
"Slow Frame #10": "Frame 525(https://en.wikipedia.org/wiki/Teletext#Data_transmission) CONTENT_FRAME_TIME 118718 - Transaction start 0,000000, main-thread time 1,969800, full paint time 3,537900, Skipped composites 0, Composite start 18,452300, Resource upload time 0,109700, GPU cache upload time 0,527200, Render time 1,745400, Composite time 2,518100"
},
"failures": [
"[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.",
"CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash."
],
"indices": [
0,
1,
2,
3,
4,
5,
6,
7,
8,
9,
10,
11
],
"featureLog": {
"features": [
{
"name": "HW_COMPOSITING",
"description": "Compositing",
"status": "available",
"log": [
{
"type": "default",
"status": "available"
}
]
},
{
"name": "D3D11_COMPOSITING",
"description": "Direct3D11 Compositing",
"status": "available",
"log": [
{
"type": "default",
"status": "available"
}
]
},
{
"name": "DIRECT2D",
"description": "Direct2D",
"status": "available",
"log": [
{
"type": "default",
"status": "available"
}
]
},
{
"name": "D3D11_HW_ANGLE",
"description": "Direct3D11 hardware ANGLE",
"status": "available",
"log": [
{
"type": "default",
"status": "available"
}
]
},
{
"name": "GPU_PROCESS",
"description": "GPU Process",
"status": "available",
"log": [
{
"type": "default",
"status": "available"
}
]
},
{
"name": "WEBRENDER",
"description": "WebRender",
"status": "available",
"log": [
{
"type": "default",
"status": "opt-in",
"message": "WebRender is an opt-in feature"
},
{
"type": "user",
"status": "available",
"message": "Force enabled by pref"
}
]
},
{
"name": "WEBRENDER_QUALIFIED",
"description": "WebRender qualified",
"status": "available",
"log": [
{
"type": "default",
"status": "available"
}
]
},
{
"name": "OMTP",
"description": "Off Main Thread Painting",
"status": "available",
"log": [
{
"type": "default",
"status": "available"
}
]
},
{
"name": "ADVANCED_LAYERS",
"description": "Advanced Layers",
"status": "available",
"log": [
{
"type": "default",
"status": "available"
}
]
}
],
"fallbacks": []
},
"crashGuards": [
{
"type": "wmfvpxvideo",
"prefName": "gfx.crash-guard.status.wmfvpxvideo"
}
]
},
"extensions": [
{
"name": "uBlock Origin",
"version": "1.18.6",
"isActive": true,
"id": "uBlock0@raymondhill.net"
}
],
"features": [
{
"name": "Firefox Monitor",
"version": "3.0",
"id": "fxmonitor@mozilla.org"
},
{
"name": "Firefox Screenshots",
"version": "37.1.0",
"id": "screenshots@mozilla.org"
},
{
"name": "Form Autofill",
"version": "1.0",
"id": "formautofill@mozilla.org"
},
{
"name": "Web Compat",
"version": "4.1.0",
"id": "webcompat@mozilla.org"
},
{
"name": "WebCompat Reporter",
"version": "1.1.0",
"id": "webcompat-reporter@mozilla.org"
}
]
}

Probably because you enabled webrender in nightly so you are seeing different defaults as in FF 66.

(In reply to Jean-Yves Avenard [:jya] from comment #15)

Probably because you enabled webrender in nightly so you are seeing different defaults as in FF 66.

Oh, yeah, I did enable webrender.

The info would only be passed after the 2nd keyframe

Depends on D26464

Also fix 10/12 bits images composition with old D3D11 compositor.

Depends on D26467

All my attempts to get proper colour out of the YUV->RGB MFT have failed. I keep this is as this is where the changes would need to be done.

Depends on D26468

Will make it easier to remove the unnecessary DXGITextureData object.

Depends on D26469

Those classes use raw pointers or references to construction objets. They can only be as temporary. Mark them as such to prevent shooting ourselves in the future.

Depends on D26470

Only D3D11TextureData inherits from it and isn't used directly.

Depends on D26471

It allows for more readable code, not having to store multiple times different storage type across multiple objects.

Now each class does one task and only deal with a single texture data type.

Depends on D26472

Attachment #9056476 - Attachment description: Bug 1540581 - P16. Mark allocation helper class as temporary. r?nical → Bug 1540581 - P16. Mark allocation helper class as RAII. r?nical
Attachment #9056476 - Attachment description: Bug 1540581 - P16. Mark allocation helper class as RAII. r?nical → Bug 1540581 - P16. Mark allocation helper classes as RAII. r?nical
Depends on: 1540907
Attachment #9056476 - Attachment description: Bug 1540581 - P16. Mark allocation helper classes as RAII. r?nical → Bug 1540581 - P16. Mark allocation helper class as RAII. r?nical
Attachment #9056478 - Attachment description: Bug 1540581 - P18 Move destination texture type choice to the D3D11 texture allocator. r?mattwoodrow → Bug 1540581 - P18. Move destination texture type choice to the D3D11 texture allocator. r?mattwoodrow

Comment on attachment 9055707 [details]
Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r?gerald,mattwoodrow

Any chances to go through those reviews?

Flags: needinfo?(nical.bugzilla)
Flags: needinfo?(jmuizelaar)
Attachment #9056474 - Attachment is obsolete: true

No color space was defined for this video, making any correct rendering impossible.
We modify the h264 stream metadata, by marking it as being bt601.
This is done with the ffmpeg command:

ffmpeg -i dom/media/test/short.mp4 -codec copy -bsf:v h264_metadata=colour_primaries=6:transfer_characteristics=6:matrix _coefficients=6 -map 0

Blocks: 1543336
Flags: needinfo?(nical.bugzilla)
Attachment #9057192 - Attachment description: Bug 1540581 - P19. Mark h264 stream as being BT601. r?bryce → Bug 1540581 - P19. Mark h264 streams as being BT601. r?bryce
Blocks: 1543359
Flags: needinfo?(jmuizelaar)

There are slight differences produced between the earlier 422 output surface and the 420; interestingly the image is sharper with 420.

Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6a6f88b71c7
P1. Fix NV12 image with OGL compositor. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/61c265181c16
P2. Add missing VideoInfo members to IPC serializer. r=bryce
https://hg.mozilla.org/integration/autoland/rev/961e937daf7b
P3. Add methods to extract color space and color depth from SPS NAL. r=bryce
https://hg.mozilla.org/integration/autoland/rev/9a4305ff9a2d
P4. Add ColorSpace/ColorDepth component to NV12 gfx::Effect. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/c8d5854c0ef0
P5. Add ColorSpace info to MacIOSurface. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/884f5dc55873
P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel
https://hg.mozilla.org/integration/autoland/rev/cc37bdabd566
P7. Use Variant instead of Union/Enum. r=kats
https://hg.mozilla.org/integration/autoland/rev/d2b6cc14a043
P8. Set decoding format back to NV12 and set colorspace. r=bryce
https://hg.mozilla.org/integration/autoland/rev/89bd3aee893e
P9. Add R16G16 type and update of P010/P016 resource update. r=sotaro
https://hg.mozilla.org/integration/autoland/rev/cf9c8ae660dd
P10. Pass colorspace data with first VP9 frame seen. r=bryce
https://hg.mozilla.org/integration/autoland/rev/bfef6e9e74d5
P11. Handle colorspace correctly with D3D11 images. r=mattwoodrow,nical
https://hg.mozilla.org/integration/autoland/rev/a0176a275ee5
P12. Pass YUV colorspace information with WMF decoder. r=bryce,mattwoodrow.
https://hg.mozilla.org/integration/autoland/rev/575c1e8291c7
P13. Properly handle colorspace with D3D11 compositors. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/574e1da58e2e
P15. Don't have base class methods return child ones. r=nical
https://hg.mozilla.org/integration/autoland/rev/9853765f91f9
P16. Mark allocation helper class as RAII. r=nical
https://hg.mozilla.org/integration/autoland/rev/30dac503bc7a
P17. Remove DXGITextureData object. r=nical
https://hg.mozilla.org/integration/autoland/rev/841b6b617577
P18. Move destination texture type choice to the D3D11 texture allocator. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/3fb8442e64d7
P19. Mark h264 streams as being BT601. r=bryce
https://hg.mozilla.org/integration/autoland/rev/ee00c85b09c5
P20. Change fuzzying leeway on macOS. r=mattwoodrow
You need to log in before you can comment on or make changes to this bug.