1540589 - Allow ./mach run to run emulator on Windows

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement, P5)

Comment 1

[Nick Alexander :nalexander [he/him]]

See also Bug 1521996, which doesn't have a blocking relationship with this ticket, but needs to take this ticket into account.

Comment 2

[Makoto Kato [:m_kato]]

(In reply to Nick Alexander :nalexander [he/him] from comment #1)

See also Bug 1521996, which doesn't have a blocking relationship with this ticket, but needs to take this ticket into account.

This issue is that it is unnecessary -enable-kvm option on windows emulator. and _get_host_platform() in testing/mozbase/mozrunner/mozrunner/devices/android_device.py returns null on Windows.

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1540589 - _get_host_platform shouldn't return None. r=nalexander

./mach run doesn't work since _get_host_platform returns None. So we should
return win32 on Windows.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44c42283d83c
_get_host_platform shouldn't return None. r=nalexander

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/44c42283d83c

Comment 6

[Chris Peterson [:cpeterson]]

Makoto, should we uplift your mozrunner Windows fix to 68 Beta?

Fennec will move to the ESR 68 channel so we should uplift fixes from 69 to 68 if they will help Fennec developers maintain the ESR 68 branch over the next year.

Comment 7

[Makoto Kato [:m_kato]]

(In reply to Chris Peterson [:cpeterson] from comment #6)

Makoto, should we uplift your mozrunner Windows fix to 68 Beta?

Fennec will move to the ESR 68 channel so we should uplift fixes from 69 to 68 if they will help Fennec developers maintain the ESR 68 branch over the next year.

OK, I will request uplift for Windows workstation.

Comment 8

[Makoto Kato [:m_kato]]

Comment on attachment 9063965 [details]
Bug 1540589 - _get_host_platform shouldn't return None. r=nalexander

Beta/Release Uplift Approval Request

• User impact if declined: This is required to support building Fennec on Windows. Fennec is moving to ESR, so our contributor doesn't use Windows workstation to build Fennec.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is ./mach command issue when using Windows to build Fennec. If not applying, detecting windows becomes script error.
• String changes made/needed: no

Comment 9

[Julien Cristau [:jcristau]]

This sounds like it can land a=npotb.

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/104b25c67fb0