Closed Bug 1540615 Opened 10 months ago Closed 4 months ago

GeckoRuntimeSetting for force-enabling zooming

Categories

(GeckoView :: General, enhancement, P1)

All
Android
enhancement

Tracking

(firefox66 wontfix, firefox67 wontfix, firefox68 wontfix, firefox69 wontfix, firefox70 wontfix, firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: JanH, Assigned: tetsuharu)

References

Details

(Whiteboard: [geckoview:m1910])

Attachments

(1 file, 1 obsolete file)

To allow recreating the "Always enable zoom" option from Fennec's accessibility settings with GeckoView.
This is controlled in Gecko globally via the browser.ui.zoom.force-user-scalable pref, and as such it should be a GeckoView runtime setting.

Rank: 25
Whiteboard: [geckoview:fenix:p2]
See Also: → 1580344

Increasing priority rank because Fenix would like to expose zooming to users in early Q4.

https://github.com/mozilla-mobile/fenix/issues/2477#issuecomment-534712792

Can I take this?

(In reply to Tetsuharu OHZEKI [:tetsuharu] [UTC+9] (a.k.a saneyuki) from comment #2)

Can I take this?

Sure! Thanks for your help. Have you built the GeckoView Example app yet? Here is our developer documentation for building GeckoView:

https://geckoview.dev/

If you have GeckoView questions, feel free to ask here in this bug or in the #mobile IRC channel on Mozilla's IRC server: https://wiki.mozilla.org/IRC

There is a bug that prevents GeckoView from running on Android's latest ARM emulator. So I recommend you test on a real Android device or Android's x86_64 emulator.

Rank: 11 → 25
Whiteboard: [geckoview:m1911]

Thanks, Tetsuharu! We get a code review for you soon.

This bug is on the Fenix (Firefox Preview) team's wish list for November, so they will be happy to see your fix here. :)

Assignee: nobody → tetsuharu.ohzeki
Attachment #9097078 - Attachment is obsolete: true

(In reply to Chris Peterson [:cpeterson] from comment #3)

(In reply to Tetsuharu OHZEKI [:tetsuharu] [UTC+9] (a.k.a saneyuki) from comment #2)

Can I take this?

Sure! Thanks for your help. Have you built the GeckoView Example app yet? Here is our developer documentation for building GeckoView:

https://geckoview.dev/

If you have GeckoView questions, feel free to ask here in this bug or in the #mobile IRC channel on Mozilla's IRC server: https://wiki.mozilla.org/IRC

There is a bug that prevents GeckoView from running on Android's latest ARM emulator. So I recommend you test on a real Android device or Android's x86_64 emulator.

Chris, thank you for your guidance.
I didn't know much about GeckoView.

Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f13152ac5d0a
Add to GeckoRuntimeSetting for force-enabling zooming. r=geckoview-reviewers,esawin

Thanks for your help, Tetsuharu! This bug fix will ship in GeckoView 71.

Priority: P2 → P1
Whiteboard: [geckoview:m1911] → [geckoview:m1910]
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.