[meta] Audit callers to nsIWidget::WidgetToScreenOffset() that call PuppetWidget::WidgetToScreenOffset()

NEW
Unassigned

Status

()

enhancement
P3
normal
4 months ago
3 months ago

People

(Reporter: hsivonen, Unassigned)

Tracking

(Depends on 3 bugs, Blocks 1 bug, {meta})

Firefox Tracking Flags

(Not tracked)

Details

We have a bunch of code that assumes that PuppetWidget content appears scaled by dpi and translated relative to the origin of the screen coordinate space.

With out-of-process iframes, PuppetWidget content can have an arbitrary transform applied to it, so every call site to nsIWidget::WidgetToScreenOffset() where the virtual call can actually go to PuppetWidget::WidgetToScreenOffset() is a potential bug site.

In bug 1532901, I'll be introducing nsIWidget methods for that, when called on PuppetWidget return the screen offset of the top-level widget (without the chrome offset) and return the child to top-level widget transform matrix (taking into account the chrome offset).

Keywords: meta
Priority: -- → P3
Summary: Audit callers to nsIWidget::WidgetToScreenOffset() that call PuppetWidget::WidgetToScreenOffset() → [meta] Audit callers to nsIWidget::WidgetToScreenOffset() that call PuppetWidget::WidgetToScreenOffset()
You need to log in before you can comment on or make changes to this bug.