1540656 - Modernize test_trr.js

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P2)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1540656 - Modernize test_trr.js r=kershaw

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1540656 - Use dns-packet node module in test_trr.js r=dragana

Depends on D25586

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1540656 - Add dns-packet and node-ip modules r=dragana

These modules are MIT licensed and they're to be used in xpcshell-tests for TRR.
They allow us to make moz-http2.js act like a true DoH server - more specifically to answer DNS queries that have actually been asked, not just a dumb character buffer.

Depends on D25671

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/408104f784ef
Modernize test_trr.js r=kershaw
https://hg.mozilla.org/integration/autoland/rev/631a1aae6fb0
Use dns-packet node module in test_trr.js r=dragana
https://hg.mozilla.org/integration/autoland/rev/70a90b960aef
Add dns-packet and node-ip modules r=dragana

Comment 5

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=70a90b960aef224ca2b85718e534e7a9b8c1e5f1&selectedJob=238092950

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238092950&repo=autoland&lineNumber=2026

Backout link: https://hg.mozilla.org/integration/autoland/rev/9ce75ad03d72e70dce19997f4822bbc8dc5522f3

[task 2019-04-04T10:16:01.663Z] 10:16:01 INFO - TEST-PASS | services/settings/test/unit/test_remote_settings.js | took 11586ms
[task 2019-04-04T10:16:01.704Z] 10:16:01 INFO - TEST-START | netwerk/test/unit/test_immutable.js
[task 2019-04-04T10:16:02.038Z] 10:16:02 WARNING - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_immutable.js | xpcshell return code: 0
[task 2019-04-04T10:16:02.038Z] 10:16:02 INFO - TEST-INFO took 333ms
[task 2019-04-04T10:16:02.039Z] 10:16:02 INFO - >>>>>>>
[task 2019-04-04T10:16:02.040Z] 10:16:02 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-04-04T10:16:02.040Z] 10:16:02 INFO - TEST-PASS | netwerk/test/unit/test_immutable.js | run_test - [run_test : 12] "" != null
[task 2019-04-04T10:16:02.040Z] 10:16:02 WARNING - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_immutable.js | run_test - [run_test : 13] "" != ""
[task 2019-04-04T10:16:02.041Z] 10:16:02 INFO - /builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/test_immutable.js:run_test:13
[task 2019-04-04T10:16:02.041Z] 10:16:02 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:523
[task 2019-04-04T10:16:02.041Z] 10:16:02 INFO - -e:null:1
[task 2019-04-04T10:16:02.042Z] 10:16:02 INFO - exiting test
[task 2019-04-04T10:16:02.042Z] 10:16:02 INFO - "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2019-04-04T10:16:02.042Z] 10:16:02 INFO - <<<<<<<
[task 2019-04-04T10:16:02.058Z] 10:16:02 INFO - TEST-START | netwerk/test/unit/test_http2.js

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a8cb77878b2
Modernize test_trr.js r=kershaw
https://hg.mozilla.org/integration/autoland/rev/69821b9a033e
Add dns-packet and node-ip modules r=dragana

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/9a8cb77878b2
https://hg.mozilla.org/mozilla-central/rev/69821b9a033e

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Need to fix and land the last patch :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/471b2063c817
Use dns-packet node module in test_trr.js r=dragana

Comment 10

[Dorel Luca [:dluca]]

Backed out changeset 471b2063c817 (bug 1540656) for XPCShell failures in dom/push/test/xpcshell/test_register_success_http2.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238766849&repo=autoland&lineNumber=9662

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=471b2063c817d3eb1dddf334963200e293953cdb

Backout:
https://hg.mozilla.org/integration/autoland/rev/9246cfa9fc3236804336650a80622fd6a1cc3146

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76a573b6acf4
Use dns-packet node module in test_trr.js r=dragana

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/76a573b6acf4