Status

enhancement
P1
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: ato, Assigned: ato)

Tracking

Details

Attachments

(2 attachments)

Assignee

Description

3 months ago

Error.jsm is untested. We should test it.

Assignee

Updated

3 months ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee

Comment 1

3 months ago

remote/Error.jsm is completely untested and that is suboptimal.
This commit adds tests for remote/Error.jsm's current behaviour.

Note that the subsequent commits make some changes to this behaviour,
but it's a conscious decision to have tests before making those
behavioural changes.

Assignee

Comment 2

3 months ago

Error messages contained extraneous colons that were inconsistent
with how JavaScript errors are usually formatted.

Examples of ill-formed formatting:

FooError:

FooError: bar:

The trailing colons should not be present in either of these cases.
Colons should only be printed when something follows. For example:

FooError

FooError: bar

FooError: bar:
	test.js:42

Comment 3

3 months ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6fba6453b064
remote: write tests for Error.jsm's current behaviour; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/304f28818b0f
remote: fix stray colons in error formatting; r=ochameau

Comment 4

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.