1540704 - upgrade to Django 2.2

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

The webapp uses Django 2.1. Today, Django 2.2 (LTS) came out and because of that work on Django 2.1 has ended. We should upgrade to Django 2.2 (LTS).

Release notes are here:

https://docs.djangoproject.com/en/2.2/releases/2.2/

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is something we should do, but there's no urgency right now so I'm making it a P3.

Comment 2

[John Whitlock [:jwhitlock]]

There is one new deprecation warning for the webapp with Django 2.2:

  /usr/local/lib/python3.6/site-packages/django/contrib/staticfiles/storage.py:498: RemovedInDjango31Warning: CachedStaticFilesStorage is deprecated in favor of ManifestStaticFilesStorage.
    self._wrapped = get_storage_class(settings.STATICFILES_STORAGE)()

The webapp uses pipeline.storage.PipelineCachedStorage, which is derived from CachedStaticFilesStorage in django-pipeline 1.6.14, the current version. There are some options for switching, and the short-term strategy is to ignore this PendingDeprecationWarning in tests (currently treated as an error by pytest).

Other than this, the Django 2.2 upgrade looks painless.

Comment 3

[John Whitlock [:jwhitlock]]

Attachment: pr 4906: bug 1540704: Update to Django 2.2

Comment 4

[John Whitlock [:jwhitlock]]

jwhitlock merged PR #4906: "bug 1540704: Update to Django 2.2" in e1e9d52.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

This has been deployed to prod.