1540741 - Warning: Each child in an array or iterator should have a unique "key" prop.

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The sub error messages are:

1. Check the render method of SourcesTree.
2. Check the render method of Accordion

STR:

1. Load http://janodvarko.cz/tests/bugzilla/1539142/
2. Open the Toolbox (in my case the Debugger panel is the default panel)
3. Click the Start Worker button
4. The worker should appear in the Sources tree and you should see the first warning in the Browser Console
5. Create BP on line 17 in Webpack/src/worker.js file
6. Wait for break and check the Browser Console for the second warning

Honza

Comment 1

[David Walsh :davidwalsh]

Attachment: FollowedSteps.png

Thank you for reporting this Honza! Unfortunately I can't reproduce with your steps. I even added a few workers in the hopes it would trigger the key problem.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Warning: Each child in an array or iterator should have a unique "key" prop.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I don't understand why you can't repro that, but the attached patch fixes that for me.

Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04537ce859c9
Warning: Each child in an array or iterator should have a unique "key" prop. r=davidwalsh

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 04537ce859c9 (Bug 1540741) for causing debugger failure CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=04537ce859c94017809e742a345c9bd2b3b37406&selectedJob=238149628

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=238149628&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/ef7519e228fb1e4557ab086ff9a1aa134635d480

Comment 6

[David Walsh :davidwalsh]

Dang; looks like we needed to add a yarn jest -u update for the snapshots.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to David Walsh :davidwalsh from comment #6)

Dang; looks like we needed to add a yarn jest -u update for the snapshots.

David, what exactly should I do to fix the patch?

Honza

Comment 8

[David Walsh :davidwalsh]

cd devtools/client/debugger/new/ and run yarn jest -u; doing so should update the out of date Jest snapshots. The test fails because those snapshots (rendered elements) don't have the key attributes you've added in your patch. After running yarn jest -u, run hg status and you should see a few changed .snap files. Add those to the patch and we should be good!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/650ab6bfa91a
Warning: Each child in an array or iterator should have a unique "key" prop. r=davidwalsh

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/650ab6bfa91a