1540757 - Assertion failure: sele->IsMalformed() (Script wasn't marked as malformed.), at /builds/worker/workspace/build/src/parser/html/nsHtml5TreeOpExecutor.cpp:525

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P2)

Description

[Jason Kratzer [:jkratzer]]

Attachment: testcase.html

Testcase found while fuzzing mozilla-central rev a5a5ddfb5178.

Assertion failure: sele->IsMalformed() (Script wasn't marked as malformed.), at /builds/worker/workspace/build/src/parser/html/nsHtml5TreeOpExecutor.cpp:525

rax = 0x0000557df6d83e20 rdx = 0x0000000000000000
rcx = 0x00007f74244fd2c5 rbx = 0x00007f7415873c00
rsi = 0x00007f742f7ac8b0 rdi = 0x00007f742f7ab680
rbp = 0x00007ffe1d3c3480 rsp = 0x00007ffe1d3c33c0
r8 = 0x00007f742f7ac8b0 r9 = 0x00007f7430909740
r10 = 0x0000000000000000 r11 = 0x0000000000000000
r12 = 0x00007ffe1d3c3438 r13 = 0x00007f742f1f4b40
r14 = 0x00007ffe1d3c3428 r15 = 0x00007f74184a14e8
rip = 0x00007f741f693155
OS|Linux|0.0.0 Linux 4.18.0-16-generic #17~18.04.1-Ubuntu SMP Tue Feb 12 13:35:51 UTC 2019 x86_64
CPU|amd64|family 6 model 94 stepping 3|1
GPU|||
Crash|SIGSEGV /SEGV_MAPERR|0x0|0
0|0|libxul.so|nsHtml5TreeOpExecutor::RunFlushLoop()|hg:hg.mozilla.org/mozilla-central:mfbt/RefPtr.h:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|296|0x0
0|1|libxul.so|nsHtml5ExecutorFlusher::Run()|hg:hg.mozilla.org/mozilla-central:parser/html/nsHtml5StreamParser.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|133|0x10
0|2|libxul.so|mozilla::SchedulerGroup::Runnable::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/SchedulerGroup.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|295|0x15
0|3|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|1180|0x15
0|4|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|482|0x11
0|5|libxul.so|mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|110|0xd
0|6|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|315|0x17
0|7|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|308|0x8
0|8|libxul.so|nsBaseAppShell::Run()|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|137|0xd
0|9|libxul.so|XRE_RunAppShell()|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|924|0x11
0|10|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|238|0x5
0|11|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|315|0x17
0|12|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|308|0x8
0|13|libxul.so|XRE_InitChildProcess(int, char**, XREChildData const*)|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|762|0xc
0|14|firefox-bin|content_process_main(mozilla::Bootstrap*, int, char**)|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|56|0x14
0|15|firefox-bin|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|263|0x11
0|16|libc-2.27.so||||0x21b97
0|17|firefox-bin|MOZ_ReportCrash|hg:hg.mozilla.org/mozilla-central:mfbt/Assertions.h:a5a5ddfb5178f8a2b30d186d3cf478da38f324ba|184|0x5

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Henri, I know it's at your wheelhouse. :)

Comment 2

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Well, this is embarrassing. Bug 1534346 still wasn't the full fix.

Comment 3

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Attachment: Bug 1540757 - Mark SVG scripts as malformed when popped by HTML breakout from foreign content.

Comment 4

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=daef8366277ea74f0ac295d53e526230708429f6

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48f7c91bbdbf
Mark SVG scripts as malformed when popped by HTML breakout from foreign content. r=alchen

Comment 6

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

https://hg.mozilla.org/projects/htmlparser/rev/1370ab8cc556

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/48f7c91bbdbf

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16493 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged