1540788 - toolchain 'stable-x86_64-unknown-linux-gnu' does not contain component 'rust-std' for target 'thumbv7neon-linux-androideabi'

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect, P1)

Description

[Benjamin De Kosnik [:bdekoz]]

Using m-c from today, and attempting a './mach bootstrap' build for arm-android (non-archive) fails on a fedora-29 (x86-64/linux) host. Archive builds are fine.

The error message:

We are now installing the following Android packages:
platform-tools
build-tools;27.0.3
platforms;android-28
emulator

You may be prompted to agree to the Android license. You may see some of
output as packages are downloaded and installed.

Warning: File /home/bkoz/.android/repositories.cfg could not be loaded.
[=======================================] 100% Computing updates...
Your version of Mercurial (4.5.3) is sufficiently modern.
Your version of Python (2.7.15) is new enough.
Your version of Rust (1.32.0) is new enough.
Rust supports aarch64-linux-android, armv7-linux-androideabi, i686-linux-android, x86_64-linux-android, x86_64-unknown-linux-gnu targets.
error: toolchain 'stable-x86_64-unknown-linux-gnu' does not contain component 'rust-std' for target 'thumbv7neon-linux-androideabi'
Error running mach:

['bootstrap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

CalledProcessError: Command '[u'/home/bkoz/.cargo/bin/rustup', u'target', u'add', u'thumbv7neon-linux-androideabi']' returned non-zero exit status 1

File "/home/bkoz/src/mozilla-gecko.target.git/python/mozboot/mozboot/mach_commands.py", line 43, in bootstrap
bootstrapper.bootstrap()
File "/home/bkoz/src/mozilla-gecko.target.git/python/mozboot/mozboot/bootstrap.py", line 434, in bootstrap
self.instance.ensure_rust_modern()
File "/home/bkoz/src/mozilla-gecko.target.git/python/mozboot/mozboot/base.py", line 676, in ensure_rust_modern
self.ensure_rust_targets(rustup)
File "/home/bkoz/src/mozilla-gecko.target.git/python/mozboot/mozboot/base.py", line 721, in ensure_rust_targets
subprocess.check_call([rustup, 'target', 'add', target])
File "/usr/lib64/python2.7/subprocess.py", line 190, in check_call
raise CalledProcessError(retcode, cmd)
<bkoz@varney> /home/bkoz/src/mozilla-gecko.target.git

Comment 1

[Nick Alexander :nalexander [he/him]]

glandium: does Bug 1539005 secretly rely on a newer Rust, i.e., Rust 1.33+? Is there something else going on here?

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1540788 - Make mach bootstrap choose arm target depending on the rust version.

Bootstrap is happy with rust version 1.32, but that version of rust
doesn't support the thumbv7neon target that we're trying to install
since bug 1539005. So install the armv7 target when rust is version
1.32.

Comment 3

[Benjamin De Kosnik [:bdekoz]]

thanks for the hint Nick!

rustup update

makes it work, and as a bonus removes the '+neon ignored' warnings from the archive build...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9bbe52bbd8d
Make mach bootstrap choose arm target depending on the rust version. r=nalexander

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e9bbe52bbd8d

Comment 7

[Raul Gurzau (:RaulG)]

Backed out on request from glandium changeset e9bbe52bbd8d (bug 1540788) for breaking bootstrap. a=backout

Backout link: https://hg.mozilla.org/mozilla-central/rev/a53585c83f44d09c2d7f29e07af5d426a7f61084

Comment 8

[Mike Hommey [:glandium]]

The problem is that rust_version is already a LooseVersion, so LooseVersion(rust_version) fails.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d79b33ce381
Make mach bootstrap choose arm target depending on the rust version. r=nalexander

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0d79b33ce381