1540804 - [generic-worker] PublicIP is required for CoT, but won't exist soon

Status: RESOLVED FIXED

(Taskcluster :: Workers, enhancement)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

The new deployments of workers will not have a public IP, but the docs mention that PublicIP is required for CoT. That may be problematic..

Comment 1

[Aki Sasaki (not active)]

Hm. I'm unaware of why we would need the public IP for CoT.
If it's related to gpg, we just removed gpg support from generic-worker, so future releases won't use it.

Comment 2

[Pete Moore [:pmoore][:pete]]

I think we might still rely on it here:

https://github.com/taskcluster/generic-worker/pull/177/files#diff-c4f3f8273ca03b7a13e4717fef4a32bfR156

Comment 3

[Aki Sasaki (not active)]

Aha. I think that's for human auditing; there's no automated verification for that key/value pair. We could remove it or make it optional if there is no public IP.

Comment 4

[Pete Moore [:pmoore][:pete]]

(In reply to Aki Sasaki [:aki] from comment #3)

Aha. I think that's for human auditing; there's no automated verification for that key/value pair. We could remove it or make it optional if there is no public IP.

I'm happy with either of those solutions, with a preference for removing it rather than making it optional, for simplicity.

Comment 5

[Chris Cooper [:coop] (he/him)]

Pete: is there still work to do here?

Comment 6

[Pete Moore [:pmoore][:pete]]

Yes, although it is quite a simple change - good for someone that wants a simple starter bug in generic-worker. Just need to remove the field, and update tests etc.

Comment 7

[Pete Moore [:pmoore][:pete]]

Attachment: GitHub Pull Request for taskcluster monorepo

Comment 8

[Pete Moore [:pmoore][:pete]]

Not actively working on this right now.

Comment 9

[Pete Moore [:pmoore][:pete]]

Actually, look like I implemented this after all, and it got released in https://github.com/taskcluster/taskcluster/releases/tag/v29.1.0.