1540821 - `firefox --profile /tmp/padding --no-remote` no longer starts a new Firefox instance with the different profile

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Matthew N. [:MattN]]

STR:

1. Launch FirefoxNightly.app from the dock with the default profile
2. Run /Applications/FirefoxNightly.app/Contents/MacOS/firefox --profile /tmp/padding from the command line

• I have never needed to use --no-remote or --new-instance before but they don't seem to help either

Expected result:
A new instance of Nightly is started with the /tmp/padding profile.

Actual result:
A new window is opened in my default Nightly profile.

[Tracking Requested - why for this release]: Usability regression for Fx devs.

Comment 1

[Matthew N. [:MattN]]

From reading the patch I see that the problem is that it's only handling -no-remote (one hyphen), not --no-remote (two hyphens):

 if ([arg isEqualToString:@"-no-remote"] || [arg isEqualToString:@"-headless"]) {

The workaround is to only use one hyphen which goes against our command line help which all use --…

Comment 2

[Yuri Z.]

Good catch, Matthew. Fixed. Thanks!

Comment 3

[Matthew N. [:MattN]]

Yuri, please attach your patch here which is only the difference from what already landed in bug 469990.

Comment 4

[Yuri Z.]

Attachment: thefix2.patch

Hi Matthew, attached patch now correctly processes both --no-remote and --headless, as well as -no-remote and -headless.

Comment 5

[Stephen A Pohl [:spohl]]

Comment on attachment 9055063 [details] [diff] [review]
thefix2.patch

Thanks! Will land this shortly.

Comment 6

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9e7edfc9ab11c9b6a0412872585545d4404c3b1
Bug 1540821: Accept `--no-remote` as equivalent of `-no-remote` and `--headless` as equivalent of `-headless` command line arguments on macOS. r=spohl

Comment 7

[Stephen A Pohl [:spohl]]

Attachment: Patch (as landed)

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d9e7edfc9ab1