Closed Bug 1540828 Opened 7 months ago Closed 6 months ago

De-dupe passwordmgr's `checkACForm` function


(Toolkit :: Password Manager, task, P3, trivial)




Tracking Status
firefox68 --- fixed


(Reporter: MattN, Assigned: MonikaMaheshwari, Mentored)


(Keywords: good-first-bug, Whiteboard: [passwords:tech-debt])


(1 file, 2 obsolete files)

Many tests have a copy of checkACForm that should be consolidated in pwmgr_common.js and probably renamed.



Can I work on this issue?

Thanks :)

Assignee: nobody → monikamaheshwari1996

On Thu, April 11, 2019, 9:58 AM GMT+3, by
Revisions: D26695 diff 88581
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpxxAds7\npatching file toolkit/components/passwordmgr/test/mochitest/test_insecure_form_field_autocomplete.html\nHunk #19 FAILED at 437\nHunk #21 FAILED at 471\nHunk #23 succeeded at 514 with fuzz 2 (offset 5 lines).\nHunk #33 succeeded at 654 with fuzz 1 (offset 8 lines).\nHunk #36 FAILED at 720\nHunk #37 FAILED at 759\nHunk #40 FAILED at 868\nHunk #41 succeeded at 920 with fuzz 2 (offset 41 lines).\n5 out of 44 hunks FAILED -- saving rejects to file toolkit/components/passwordmgr/test/mochitest/test_insecure_form_field_autocomplete.html.rej\npatching file toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html\nHunk #23 succeeded at 493 with fuzz 2 (offset 1 lines).\nHunk #33 succeeded at 626 with fuzz 1 (offset -2 lines).\nHunk #35 FAILED at 669\nHunk #36 FAILED at 700\nHunk #37 FAILED at 739\nHunk #40 FAILED at 827\n4 out of 44 hunks FAILED -- saving rejects to file toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html.rej\nabort: patch failed to apply', '')

Flags: needinfo?(monikamaheshwari1996)
Keywords: checkin-needed

Hey can you help me on how to rebase manually.

Flags: needinfo?(monikamaheshwari1996)

If you don't have the patch applied in the local repository anymore:

a) If you use moz-phab, run: moz-phab patch D26695 --apply-to .
b) Else (using arc directly): arc patch D26695 --nobranch

Some of the changes will fail to apply, likely due to the changes in bug 1325778 and bug 1147563. This need to be fixed, see

If you still have the patch in your repository:

Run: hg heads
Check for the revision hash of your change and copy it

Run: hg update revisionHashOfYourChange
Activates your changes.

Do the rebase, run: hg rebase -s . -d central
There should be the conflicts and they need to be fixed like mentioned above.

Have updated the revision. Please check.

Pushed by
De-dupe passwordmgr checkACForm function r=MattN

Created second revision as previous revision was closed.

Flags: needinfo?(monikamaheshwari1996)

Bug 1540828 checkACForm function

mochitest failures at test_autofill_sandboxed.html solved

Created another revision which has solved the failure.

Flags: needinfo?(monikamaheshwari1996)

Hi Monika, in the future you can re-open a revision using the dropdown at the bottom of the review page:

You shouldn't create a new revision for the same change.

Type: defect → task
Attachment #9057497 - Attachment is obsolete: true
Attachment #9056879 - Attachment is obsolete: true
Attachment #9057927 - Attachment description: Bug 1540828 → Bug 1540828 - De-dupe passwordmgr checkACForm function.
Pushed by
De-dupe and rename passwordmgr checkACForm function. r=MattN
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.