1540828 - De-dupe passwordmgr's `checkACForm` function

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P3)

Description

[Matthew N. [:MattN]]

Many tests have a copy of checkACForm that should be consolidated in pwmgr_common.js and probably renamed.

Definitions: https://searchfox.org/mozilla-central/search?q=function+checkACForm&case=false&regexp=false&path=

pwmgr_common.js

Comment 1

[Monika Maheshwari [:MonikaMaheshwari]]

Can I work on this issue?

Comment 2

[Matthew N. [:MattN]]

Yes, go ahead.

Comment 3

[Monika Maheshwari [:MonikaMaheshwari]]

Thanks :)

Comment 4

[Monika Maheshwari [:MonikaMaheshwari]]

Attachment: Bug 1540828 De-dupe passwordmgr checkACForm function

Comment 5

[Andreea Pavel [:apavel]]

On Thu, April 11, 2019, 9:58 AM GMT+3, by [e-mail].
Revisions: D26695 diff 88581
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpxxAds7\npatching file toolkit/components/passwordmgr/test/mochitest/test_insecure_form_field_autocomplete.html\nHunk #19 FAILED at 437\nHunk #21 FAILED at 471\nHunk #23 succeeded at 514 with fuzz 2 (offset 5 lines).\nHunk #33 succeeded at 654 with fuzz 1 (offset 8 lines).\nHunk #36 FAILED at 720\nHunk #37 FAILED at 759\nHunk #40 FAILED at 868\nHunk #41 succeeded at 920 with fuzz 2 (offset 41 lines).\n5 out of 44 hunks FAILED -- saving rejects to file toolkit/components/passwordmgr/test/mochitest/test_insecure_form_field_autocomplete.html.rej\npatching file toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html\nHunk #23 succeeded at 493 with fuzz 2 (offset 1 lines).\nHunk #33 succeeded at 626 with fuzz 1 (offset -2 lines).\nHunk #35 FAILED at 669\nHunk #36 FAILED at 700\nHunk #37 FAILED at 739\nHunk #40 FAILED at 827\n4 out of 44 hunks FAILED -- saving rejects to file toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html.rej\nabort: patch failed to apply', '')

Comment 6

[Monika Maheshwari [:MonikaMaheshwari]]

Hey can you help me on how to rebase manually.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

If you don't have the patch applied in the local repository anymore:

a) If you use moz-phab, run: moz-phab patch D26695 --apply-to .
b) Else (using arc directly): arc patch D26695 --nobranch

Some of the changes will fail to apply, likely due to the changes in bug 1325778 and bug 1147563. This need to be fixed, see https://www.mercurial-scm.org/wiki/TutorialConflict

If you still have the patch in your repository:

Run: hg heads
Check for the revision hash of your change and copy it

Run: hg update revisionHashOfYourChange
Activates your changes.

Do the rebase, run: hg rebase -s . -d central
There should be the conflicts and they need to be fixed like mentioned above.

Comment 8

[Monika Maheshwari [:MonikaMaheshwari]]

Have updated the revision. Please check.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03ed53e600d4
De-dupe passwordmgr checkACForm function r=MattN

Comment 10

[Andreea Pavel [:apavel]]

Backed out for failing eslint at test_autofill_from_bfcache.html:57:7

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=239614623&revision=03ed53e600d458cef860664cbee5d5fdaf8e33f3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239641755&repo=autoland&lineNumber=286

Backout: https://hg.mozilla.org/integration/autoland/rev/5d5e4df2976a4649e0a717f75c5f311ea1385046

Comment 11

[Monika Maheshwari [:MonikaMaheshwari]]

Attachment: Bug 1540828 checkACForm function

Comment 12

[Monika Maheshwari [:MonikaMaheshwari]]

Created second revision as previous revision was closed.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbae72da0dc4
checkACForm function r=aryx

Comment 14

[Cristian Brindusan [:cbrindusan]]

Backed out changeset cbae72da0dc4 (Bug 1540828) for mochitest failures at test_autofill_sandboxed.html

Backout: https://hg.mozilla.org/integration/autoland/rev/a9b02d3daee397853a8498f344f2e237e67d3545

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=cbae72da0dc4b0ab70cb29dbec66b460c83c9d7f&selectedJob=239932345

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239932345&repo=autoland&lineNumber=17193

Comment 15

[Monika Maheshwari [:MonikaMaheshwari]]

Attachment: Bug 1540828 - De-dupe passwordmgr checkACForm function.

Bug 1540828 checkACForm function

mochitest failures at test_autofill_sandboxed.html solved

Comment 16

[Monika Maheshwari [:MonikaMaheshwari]]

Created another revision which has solved the failure.

Comment 17

[Matthew N. [:MattN]]

Hi Monika, in the future you can re-open a revision using the dropdown at the bottom of the review page: https://cl.ly/3157b8b25122

You shouldn't create a new revision for the same change.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2165a58403b6
De-dupe and rename passwordmgr checkACForm function. r=MattN

Comment 19

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2165a58403b6