Closed
Bug 1540835
Opened 5 years ago
Closed 5 years ago
Add tests for the Picture-in-Picture toggle
Categories
(Toolkit :: Video/Audio Controls, defect, P1)
Toolkit
Video/Audio Controls
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(2 files)
Once bug 1535354 lands, we should get some automated tests in there for it.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → mconley
Priority: -- → P1
|
|
Assignee | |
Comment 1•5 years ago
|
||
We needed to handle the case where closePictureInPicture was being called on a window
that had already been closed but not yet GC'd.
Depends on D26807
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D27001
|
|
Assignee | |
Comment 3•5 years ago
|
||
This still hasn't landed because I'm trying to get the tests to pass reliably in automation:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6fdb6086b4854667c2641ed2acd5ac545151c3a
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1eae82ecc532 Make Picture-in-Picture window closing more resilient to races. r=Felipe https://hg.mozilla.org/integration/autoland/rev/3fe91f0bfbff Add some automated tests for the Picture-in-Picture toggle. r=Felipe
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1eae82ecc532
https://hg.mozilla.org/mozilla-central/rev/3fe91f0bfbff
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Updated•5 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•