1540835 - Add tests for the Picture-in-Picture toggle

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Once bug 1535354 lands, we should get some automated tests in there for it.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1540835 - Make Picture-in-Picture window closing more resilient to races. r?felipe

We needed to handle the case where closePictureInPicture was being called on a window
that had already been closed but not yet GC'd.

Depends on D26807

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1540835 - Add some automated tests for the Picture-in-Picture toggle. r?felipe

Depends on D27001

Comment 3

[Mike Conley (:mconley) (:⚙️)]

This still hasn't landed because I'm trying to get the tests to pass reliably in automation:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6fdb6086b4854667c2641ed2acd5ac545151c3a

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1eae82ecc532
Make Picture-in-Picture window closing more resilient to races. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/3fe91f0bfbff
Add some automated tests for the Picture-in-Picture toggle. r=Felipe

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1eae82ecc532
https://hg.mozilla.org/mozilla-central/rev/3fe91f0bfbff