Closed Bug 154086 Opened 23 years ago Closed 23 years ago

Want /css to display current css setting

Categories

(Other Applications :: ChatZilla, enhancement)

x86
Windows 95
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: rginda)

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

Although /eval client.DEFAULT_STYLE will show you the current css setting I think /css should as well as it is more intuitive.
Attached patch Proposed patch (obsolete) — Splinter Review
Keywords: patch, polish, review, ui
Attachment #89048 - Flags: review+
Comment on attachment 89048 [details] [diff] [review] Proposed patch Please update the .properties file to show that the parameter is optional, and add a line to the help text that says what heppens when the parameter is not provided. After that, r=rginda.
Attached patch Patch v1.1Splinter Review
Added []s to the usage to show that the parameter is optional. Changed the help text from "Sets" to "Sets or displays".
Attachment #89048 - Attachment is obsolete: true
Comment on attachment 89050 [details] [diff] [review] Patch v1.1 r=rginda
Attachment #89050 - Flags: review+
Fix was checked in by timeless.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
- if (!e.inputData) - return false; Did we lose this false return value?
returning false from a command handler tells chatzilla that there was a problem with the parameters, and that it should display usage information for the command. I don't think that's what we want here.
Ahh, I see now. Makes perfect sense.
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: