Closed Bug 1540875 Opened 3 years ago Closed 3 years ago

JavaScript warning: resource://gre/modules/UrlClassifierLib.jsm, line 34: Array.slice is deprecated; use Array.prototype.slice instead

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Noticed the following debug logging spam when running ./mach wpt (command here[1], though probably this happens with lots of commands; anything that exercises this JSM in the background):

JavaScript warning: resource://gre/modules/UrlClassifierLib.jsm, line 34:
 Array.slice is deprecated; use Array.prototype.slice instead

searchfox link:
https://searchfox.org/mozilla-central/rev/201450283cddc9e409cec707acb65ba6cf6037b1/toolkit/components/url-classifier/UrlClassifierLib.jsm#34

[1] The exact command I used (probably not important) was:

xvfb-run ./mach wpt --verify \
testing/web-platform/tests/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html

Bug 1384040 was just moving code around.

Depends on: 383217
No longer depends on: 1384040

Thanks. I depended on searchfox blame too heavily. :)

I verified locally that the warning goes away with this patch.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Component: General → Safe Browsing
No longer depends on: 383217
Regressed by: 383217
Keywords: regression
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a95cb35d2b20
Switch from Array.slice to Array.prototype.slice in UrlClassifierLib.jsm, to address JS warning. r=marco
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.