1540875 - JavaScript warning: resource://gre/modules/UrlClassifierLib.jsm, line 34: Array.slice is deprecated; use Array.prototype.slice instead

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Daniel Holbert [:dholbert]]

Noticed the following debug logging spam when running ./mach wpt (command here[1], though probably this happens with lots of commands; anything that exercises this JSM in the background):

JavaScript warning: resource://gre/modules/UrlClassifierLib.jsm, line 34:
 Array.slice is deprecated; use Array.prototype.slice instead

searchfox link:
https://searchfox.org/mozilla-central/rev/201450283cddc9e409cec707acb65ba6cf6037b1/toolkit/components/url-classifier/UrlClassifierLib.jsm#34

Comment 1

[Daniel Holbert [:dholbert]]

[1] The exact command I used (probably not important) was:

xvfb-run ./mach wpt --verify \
testing/web-platform/tests/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html

Comment 2

[Marco Castelluccio [:marco] (back Aug 22)]

Bug 1384040 was just moving code around.

Comment 3

[Daniel Holbert [:dholbert]]

Thanks. I depended on searchfox blame too heavily. :)

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: Bug 1540875: Switch from Array.slice to Array.prototype.slice in UrlClassifierLib.jsm, to address JS warning. r?marco

Comment 5

[Daniel Holbert [:dholbert]]

I verified locally that the warning goes away with this patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a95cb35d2b20
Switch from Array.slice to Array.prototype.slice in UrlClassifierLib.jsm, to address JS warning. r=marco

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a95cb35d2b20