Closed Bug 1540907 Opened 9 months ago Closed 8 months ago

mingw build: missing some constants.

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jya, Assigned: tjr)

References

Details

Attachments

(1 file)

Seen in https://treeherder.mozilla.org/logviewer.html#?job_id=236820478&repo=try

builds/worker/workspace/build/src/dom/media/platforms/wmf/WMFUtils.cpp:74:10: error: use of undeclared identifier 'MFVideoTransferMatrix_BT2020_10'; did you mean 'MFVideoTransferMatrix_BT601'?
/builds/worker/workspace/build/src/dom/media/platforms/wmf/WMFUtils.cpp:75:10: error: use of undeclared identifier 'MFVideoTransferMatrix_BT2020_12'; did you mean 'MFVideoTransferMatrix_BT601'?
/builds/worker/workspace/build/src/dom/media/platforms/wmf/WMFUtils.cpp:75:10: error: duplicate case value 'MFVideoTransferMatrix_BT601'
/builds/worker/workspace/build/src/dom/media/platforms/wmf/WMFUtils.cpp:79:10: error: duplicate case value 'MFVideoTransferMatrix_BT601'
make[4]: *** [WMFUtils.o] Error 1

Those are supposed to be defined since Windows Vista in mfobjects.h (include Mfidl.h)

https://docs.microsoft.com/en-us/windows/desktop/api/mfobjects/ne-mfobjects-_mfvideotransfermatrix

Following bug 1540581, unless this bug is fixed, compilation via MinGW will be broken.

Being Tier2, I don't plan on waiting for this bug to be fixed.

thanks.

Blocks: 1540581

It's committed upstream, we need to update mingw-w64.

I messed mingw-w64 commit, it didn't contain generated parts. We will need d539d36fd573e688ec7ad9dc840e3826a65419b1

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6d48028244b
Bump MinGW version to pick up MFVideoTransferMatrix constants r=froydnj

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.