Closed Bug 1540927 Opened 2 years ago Closed 2 years ago

Make Selection and nsFrameSelection use PresShell directly rather than via nsIPresShell

Categories

(Core :: DOM: Selection, defect, P3)

Product:
Core
Component:
DOM: Selection
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(2 files)

Bug 1540927 - part 1: Make nsFrameSelection treat mozilla::PresShell directly rather than via nsIPresShell
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540927 - part 2: Make Selection use mozilla::PresShell directly rather than via nsIPresShell
47 bytes, text/x-phabricator-request
Details | Review

This patch makes nsFrameSelection treat mozilla::PresShell directly and
rename nsFrameSelection::GetShell() to nsFrameSelection::GetPresShell() because of avoiding confusion betweenPresShellvs.DocShell`.

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/a54a5426b0c1
part 1: Make nsFrameSelection treat mozilla::PresShell directly rather than via nsIPresShell r=smaug
https://hg.mozilla.org/integration/autoland/rev/efa1c56e77aa
part 2: Make Selection use mozilla::PresShell directly rather than via nsIPresShell r=smaug

https://hg.mozilla.org/mozilla-central/rev/a54a5426b0c1
https://hg.mozilla.org/mozilla-central/rev/efa1c56e77aa

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.