1540931 - [remote-dbg-next] When previous connection failed, same error of connection will occur at next connecting timing

Status: NEW

(DevTools :: about:debugging, defect, P3)

Description

[Daisuke Akatsuka (:daisuke)]

This is a followup of bug 1505131

As Julian mentioned at here, we still have issue for connection.
Copy and paste the STRs which Julian wrote to here again.

Prerequisite:

• add a network location that will not match anything (eg "blablabla:1234")
• connect a phone via USB, start a debuggable with connection prompt enabled

STRs:

• open about:debugging, enable USB debugging if needed
• in the sidebar, click on connect for blablabla:1234
• (it should show the error message)
• in the sidebar, click on connect for the USB runtime

ER: it should show the warning after 1s
AR: it shows the a connection failed error, same message as for the network runtime. If you click on connect again then you get a connection prompt on the device and the flow resumes as expected.

I have investigated a bit, the error occurs from https://searchfox.org/mozilla-central/source/devtools/shared/security/socket.js#328
So, we might need to investigate around https://searchfox.org/mozilla-central/source/devtools/shared/security/socket.js#253 as well.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Actually, we could reproduce this issue two weeks ago, but I could not reproduce with current m-c.
Julian, could you confirm in your environment just in case?

Comment 2

[Julian Descottes [:jdescottes]]

Same here, I cannot reproduce the issue anymore! If you have time, could you run a quick mozregression to find which changeset fixed this? It would be great to check if a test was added for this.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Oh, I can reproduce with today's m-c. I'll investigate again.

Comment 4

[Daisuke Akatsuka (:daisuke)]

I have investigated other OS as well though, it seems this happens only OSX. I could not reproduce on Ubuntu 18.04.1 LTS and Windows Pro 10.