Closed Bug 1540939 Opened 1 year ago Closed 11 months ago

Remove SnippetsFeed and related components

Categories

(Firefox :: New Tab Page, task, P1)

task

Tracking

()

VERIFIED FIXED
Firefox 68
Iteration:
68.2 - Apr 1 - 14
Tracking Status
firefox68 --- verified

People

(Reporter: andreio, Assigned: andreio)

References

Details

(Keywords: github-merged)

Attachments

(2 files)

Snippets are now handled by ASRouter, we should remove this component.

Iteration: --- → 68.2 - Apr 1 - 14
Priority: -- → P1

QA Steps:

  1. (Set snippets endpoint to match Release) In a new firefox profile, got to about:config and set
  • browser.newtabpage.activity-stream.asrouter.providers.snippets to
  • {"id":"snippets","enabled":true,"type":"remote","url":"https://snippets.cdn.mozilla.net/us-west/bundles/bundle_3e0777350c57defbe408dbe0859c4eaa597e3eea.json","updateCycleInMs":14400000}
  1. (Fake profile age) Go to the firefox profile folder and look for a folder named times.json
  • Go to about:profiles to find the currently used profile and its location on disk
  • Example value to set in the file {"firstUse":1522843725925,"created":1522843725924}
  1. After (1) and (2) restart the browser and you should see snippets
  2. Using about:preferences make sure you can turn snippets off/on

Note:

  • First new tab after re-enabling snippets won't have a snippet.
Assignee: nobody → andrei.br92
Type: defect → task
Blocks: 1546190
Status: NEW → RESOLVED
Iteration: 68.2 - Apr 1 - 14 → 68.3 - Apr 15 - 28
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Looks like there's a m-c patch for this to land?

Status: RESOLVED → REOPENED
Iteration: 68.3 - Apr 15 - 28 → 68.2 - Apr 1 - 14
Flags: needinfo?(andrei.br92)
Resolution: FIXED → ---

Queued for landing. Thanks.

Flags: needinfo?(andrei.br92)
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11de829f1358
Remove SnippetsFeed and related components r=k88hudson
Status: REOPENED → RESOLVED
Closed: 11 months ago11 months ago
Resolution: --- → FIXED

I have verified this issue with the latest Firefox Beta (68.0b4 Build ID - 20190523115432) and latest Firefox Nightly (69.0a1 Build ID - 20190523115432) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the snippets are no longer displayed if are disabled from the "about:preferences#home" page.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.