Closed Bug 1540969 Opened 7 months ago Closed 7 months ago

Get rid of nsPICommandUpdater

Categories

(Core :: XUL, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

It's not used by JS so that we can get rid of it.

nsPICommandUpdater is a scriptable interface, but nobody refers it from JS,
and it's implemented only by nsCommandManager. Therefore, we can get rid
of this interface.

Additionally, nsCommandManager::Init() is called only by nsDocShell, which
is the only instantiater of the class, and returns error only when given window
is nullptr. Therefore, we can make the constructor take the window instead.

Priority: -- → P3
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/395ff10d7deb
Get rid of nsPICommandUpdater r=bzbarsky
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.