Closed Bug 1540991 Opened 6 years ago Closed 6 years ago

Consider moving completion from HashStore to PrefixSet

Categories

(Toolkit :: Safe Browsing, task, P1)

task

Tracking

()

RESOLVED DUPLICATE of bug 1531354

People

(Reporter: dimi, Assigned: dimi)

References

Details

For SafeBrowsing V2, we have 4-bytes prefixes and 32-bytes completions.
32-bytes completions are store in .sbstore and 4-bytes prefixes are store in .pset. We have to read both of the files during startup to fully enable SafeBrowsing.

In SafeBrowsing V4, variable-length prefix set is introduced and we can store prefixes with different length into a single file (.vlpset).

We should consider using the same way to store 4-bytes prefix and 32-bytes completions for V2, by doing so, we can make HashStore files only be read when a SafeBrowsing update is triggered.

Blocks: 1540993
No longer blocks: 1540993
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Type: defect → task
Priority: P2 → P1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.