1541040 - Lando should not warn that commit is not accepted if one reviewer accepted and one person requested changes

Status: RESOLVED INVALID

(Conduit :: Lando, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://phabricator.services.mozilla.com/D22770 got accepted by mats. The attachment in bug 1533554 suggests mats was the only person set as a reviewer. A second person requested changes.

Actual behavior:

• "View Stack in Lando" link greyed out but still clickable.
• Lando warned with "Is not Accepted".

Comment 1

[:glob ✱]

the description of the attachment in bugzilla is not correlated with the actual reviewers requested or set.

please use the "phabricator revisions" table in bugzilla, which correctly shows both reviewers and their correct statuses.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

That says the patch got accepted by a person while Lando said it hasn't been accepted by anybody.

Comment 3

[:glob ✱]

lando and phabricator's assessment of the state of this revision is correct - a reviewer asked for changes and has not accepted that those changes have been made.

either the original reviewer who requested changes needs to mark the updated revision as accepted, or that reviewer should have been removed.

Comment 4

[:glob ✱]

Attachment: lando's warning

Comment 5

[:glob ✱]

Attachment: phabricator's warning