Closed Bug 1541062 Opened 5 years ago Closed 5 years ago

Remove eval() from updates.js

Categories

(Core :: DOM: Security, task, P3)

Product:
Core
Component:
DOM: Security
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: jallmann, Assigned: jallmann)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-backlog1])

Attachments

(1 file)

Bug 1541062, Remove eval() from updates.js, r=gijs
47 bytes, text/x-phabricator-request
Details | Review

Removing eval() from system privileged code as part of Bug 1473549.

https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/content/updates.js#302

This eval() in the updates-wizard code needs to go.

Remove eval() from updates.js
Refactor code to make mapping of pageids to js-objects obsolete
Remove now unnecessary object attributes from wizard pages in updates.xul

Type: defect → task
Status: NEW → ASSIGNED
Keywords: checkin-needed

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2d54ea3f6208
Remove eval() from updates.js, r=Gijs

Keywords: checkin-needed

https://hg.mozilla.org/mozilla-central/rev/2d54ea3f6208

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: