1541147 - [Coverity] Create a try job that performs coverity static-analysis for patches

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Andi [:andi]]

In order to continue and move our review-time coverity analysis from relman infrastructure to ci, we need something very similar with Bug 1535355.

Comment 1

[Andi [:andi]]

Attachment: Bug 1541147 - [Coverity] Create a try job that performs coverity static-analysis for patches.

Comment 2

[Andi [:andi]]

And the result:
https://tools.taskcluster.net/groups/ZguQ4IzgSYCyVhrIFA8IKQ/tasks/aAomN6MEQqOJomOlApmo_Q/runs/0/logs/public%2Flogs%2Flive.log

The resulting json: https://taskcluster-artifacts.net/aAomN6MEQqOJomOlApmo_Q/0/public/code-review/coverity.json

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3779175a4d7f
[Coverity] Create a try job that performs coverity static-analysis for patches. r=bastien

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for gecko decision task bustage

backout: https://hg.mozilla.org/integration/autoland/rev/7b3fc26d7fbb3e1995e71abf7b3d9d1de61ccd6d

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3779175a4d7fdd3eb5b6fd380342d41c22764690

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238375870&repo=autoland&lineNumber=3355

[task 2019-04-05T12:29:25.636Z] Creating task with taskId Jb1t1pvLTl2e0zeuQKrMyA for build-linux-rusttests/debug
[task 2019-04-05T12:29:25.696Z] Creating task with taskId eybfr8o-TneFnc1F2rn3Ng for source-test-python-mozterm-windows10-64/opt-py2
[task 2019-04-05T12:29:27.151Z] Traceback (most recent call last):
[task 2019-04-05T12:29:27.151Z] File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 203, in taskgraph_decision
[task 2019-04-05T12:29:27.151Z] return taskgraph.decision.taskgraph_decision(options)
[task 2019-04-05T12:29:27.151Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 193, in taskgraph_decision
[task 2019-04-05T12:29:27.151Z] create_tasks(tgg.graph_config, tgg.morphed_task_graph, tgg.label_to_taskid, tgg.parameters)
[task 2019-04-05T12:29:27.151Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/create.py", line 107, in create_tasks
[task 2019-04-05T12:29:27.151Z] f.result()
[task 2019-04-05T12:29:27.151Z] File "/builds/worker/checkouts/gecko/third_party/python/futures/concurrent/futures/_base.py", line 398, in result
[task 2019-04-05T12:29:27.152Z] return self.__get_result()
[task 2019-04-05T12:29:27.152Z] File "/builds/worker/checkouts/gecko/third_party/python/futures/concurrent/futures/thread.py", line 55, in run
[task 2019-04-05T12:29:27.152Z] result = self.fn(*self.args, **self.kwargs)
[task 2019-04-05T12:29:27.152Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/create.py", line 133, in create_task
[task 2019-04-05T12:29:27.152Z] res.raise_for_status()
[task 2019-04-05T12:29:27.152Z] File "/builds/worker/checkouts/gecko/third_party/python/requests/requests/models.py", line 840, in raise_for_status
[task 2019-04-05T12:29:27.152Z] raise HTTPError(http_error_msg, response=self)
[task 2019-04-05T12:29:27.152Z] HTTPError: 403 Client Error: Forbidden for url: http://taskcluster/queue/v1/task/dQtX8_j8Td6hwBwt0H9YWA
[taskcluster 2019-04-05 12:29:28.045Z] === Task Finished ===
[taskcluster 2019-04-05 12:29:38.024Z] Unsuccessful task run with exit code: 1 completed in 84.358 seconds

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2a6e9aafcf6
[Coverity] Create a try job that performs coverity static-analysis for patches. r=bastien

Comment 6

[Andi [:andi]]

Dustin can you help here please?

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0913f775a771
Backed out changeset e2a6e9aafcf6 for gecko decision task failure. CLOSED TREE

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac130652ae81
[Coverity] Create a try job that performs coverity static-analysis for patches. r=bastien

Comment 9

[Razvan Maries]

Backed out for Gecko Decision Task bustage.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ac130652ae81d266d1d3d1acecf78f78d5eb2686&selectedJob=238554764

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238554764&repo=autoland&lineNumber=3341

Backout: https://hg.mozilla.org/integration/autoland/rev/a765634b9ec26b122c094ad5def8e70ea5c23e17

Tomprince said on irc:

10:22 AM It is adding a new task, which requires permissions that autoland doesn't have.
10:23 AM And that task isn't intended to run on autoland, but is.
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238555498&repo=autoland&lineNumber=3008 is the actual error (you have to scroll up aways)
10:26 AM In this particular case, notice the missing scope is something coverity, which the commit also talks about

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e2aef09165a
[Coverity] Create a try job that performs coverity static-analysis for patches. r=bastien

Comment 11

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 7e2aef09165a (bug 1541147) on request by Andi

Backout: https://hg.mozilla.org/integration/autoland/rev/248454418988cd588c14721920bcfc995bb973ca

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7e2aef09165a8ea94a27a8ee51537bb8f9c8a99e

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/674a4d255565
[Coverity] Create a try job that performs coverity static-analysis for patches. r=bastien

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/674a4d255565