1541175 - When entering Responsive Design Mode, UI should be fixed at 100% zoom

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Brad Werth [:bradwerth]]

Steps to Reproduce:

1. Open any page.
2. Set the full zoom level to 150%
3. Start Responsive Design Mode

Actual Results: the RDM UI will appear magnified to 150%
Expected Results: the RDM UI should appear at 100% zoom

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1541175 Part 2: Force RDM UI to be at 100% zoom.

Comment 2

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=677d53746225f8f07bb16477031887372b6e764e

Comment 3

[Brad Werth [:bradwerth]]

Due to review comments, and a desire to more completely fix the problem, this will need to depend on Bug 1541158.

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1541175 Part 1: Give embedded browsers custom getters and setters for zoom properties.

Comment 5

[Brad Werth [:bradwerth]]

Attachment: Bug 1541175 Part 2: Allow the ZoomManager to associate zoom sources with browsers.

This supports embedded browsers (as used in devtools Responsive Design
Mode) as a source of truth for zoom values. The ZoomManager can now
associate a zoom source for each browser it might later be asked to get
or set zoom values.

Depends on D26394

Comment 6

[Brad Werth [:bradwerth]]

Attachment: Bug 1541175 Part 3: Set and clear ZoomManager zoom sources for RDM panes.

Depends on D26395

Comment 7

[Brad Werth [:bradwerth]]

This is becoming a lot more complicated than I expected. The attached patches get us close to desired behavior, but there still are cases where the zoom UI values can be incorrect relative to the actual zoom level of the RDM content.

Comment 8

[Brad Werth [:bradwerth]]

Attachment: Bug 1541175 Part 3: Update test expectations.

Depends on D26045

Comment 9

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fadc5ae087c304ebffb81e5d1d5d1666041012b

Comment 10

[Brad Werth [:bradwerth]]

Attachment: Bug 1541175 Part 1: Prevent fullZoom and textZoom from being remapped on RDM docshell swap.

There is no need to transfer these properties because the swap makes
the outer browser act as if it is remote, and then the message manager
tunnel ensures that the outer browser will get and set the zoom values
from the inner browser.

Comment 11

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c09f912636ebf458377acbf2baaf3f574fd025bf

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b377b5bdd883
Part 1: Prevent fullZoom and textZoom from being remapped on RDM docshell swap. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/2f85ada34acb
Part 2: Force RDM UI to be at 100% zoom. r=pbro,ochameau
https://hg.mozilla.org/integration/autoland/rev/20a54f437d51
Part 3: Update test expectations. r=ochameau

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b377b5bdd883
https://hg.mozilla.org/mozilla-central/rev/2f85ada34acb
https://hg.mozilla.org/mozilla-central/rev/20a54f437d51

Comment 15

[Rares Doghi, Desktop QA]

Hi This issue is Verified as fixed in Firefox Nightly 69.0a1 (2019-06-03). I will mark this issue accordingly.