1541179 - Update and tidy suite/app/ build files

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Ian Neal]

Port various patches from browser/app build files and tidy up:

• Bug 743280 - cosmetic edits removed from bug 739710
• Bug 748389 - consolidate Mac bundle identifier logic in configure, and use it to specify the Mac bundle ID of the installing app in installed web apps' bundles
• Bug 787180 - Switch between FINAL_TARGET and DIST/bin in various places under browser/
• Bug 910781 - add support for FINAL_TARGET_FILES
• Bug 1207890 - Post: Hacks to make --disable-compile-environment work on Mac OS X
• Bug 1244999 - Move icon-related DEFINES to moz.build in browser/app
• Bug 1352982 - clobber OSX .app directory before rsyncing files in
• Bug 1380690 - Part 1 - Save repo and object dir paths in Mac bundle Info.plist files
• Bug 862770 - Fix --disable-compile-environment a little
• Bug 1235982 - Investigate enabling VS2015's "Control Flow Guard" (CFG) security checks using /guard:cf
• Bug 793735 - Make XRE_StartupTimelineRecord() generate TimeStamps and modify its callers to use the appropriate timers
• Bug 858928 - Switch XRE_StartupTimelineRecord() from PRTime to TimeStamp
• Bug 1347360 - Remove unnecessary USE_LIBS directive
• Bug 1387650 - Associate json files with the browser on OS X
• Bug 1405577 - Restore the ability to open new windows in new spaces when a window is already in fullscreen mode on macOS
• Bug 1424709 - Force disable the OSX system "nano allocator"
• Bug 1305339 and bug 1310518 - improve downloads quarantine support and fix crashes

Comment 1

[Ian Neal]

Attachment: Port bug 743280

Comment 2

[Ian Neal]

Attachment: a) Port bug 743280

Also removes unneeded substitutions for InfoPlist.strings.in as only @MAC_APP_NAME@ exists

Comment 3

[Ian Neal]

Attachment: b) Port bug 748389

Comment 4

[Ian Neal]

Attachment: Port bug 787180

Comment 5

[Ian Neal]

Attachment: Port bug 787180

Include reversals in Bug 789529 - Fix for updater tests can't find channel-prefs.js - move channel-prefs back to its gre subdir

Comment 6

[Ian Neal]

Attachment: Port Bug 910781

Comment 7

[Ian Neal]

Attachment: c) Port bug 787180

Less replacements with FINAL_TARGET

Comment 8

[Ian Neal]

Attachment: d) Port Bug 910781

Unbitrotted

Comment 9

[Ian Neal]

Attachment: e) Port bug 1207890

Comment 10

[Ian Neal]

Attachment: f) Port bug 1244999

As the DEFINES names don't match the icon names, solution isn't as neat as the Firefox version.

Comment 11

[Ian Neal]

Attachment: Port bug 394984 and bug 1278042

Comment 12

[Ian Neal]

Attachment: h) Port bug 1352982

Comment 13

[Ian Neal]

Attachment: i) Port bug 1380690

Comment 14

[Ian Neal]

Attachment: g) Port bug 394984 and bug 1278042

Factor in fix from bug 1407285

Comment 15

[Ian Neal]

Attachment: j) Port bug 862770

Comment 16

[Ian Neal]

Attachment: k) Port bug 1235982

Comment 17

[Ian Neal]

Attachment: l) Port bug 793735

Includes changes from Bug 793735, Bug 858928 and Bug 1045783

Comment 18

[Ian Neal]

Attachment: m) Port bug 1347360

Comment 19

[Ian Neal]

Attachment: n) Port changes to Info.plist.in

Comment 20

[Ian Neal]

Attachment: Tidy up license file insertion

Comment 21

[Ian Neal]

Attachment: a) Port bug 743280

Comment 22

[Ian Neal]

Attachment: b) Port bug 748389

Comment 23

[Ian Neal]

Attachment: c) Port bug 787180

Comment 24

[Ian Neal]

Attachment: d) Port Bug 910781

Comment 25

[Ian Neal]

Attachment: e) Port bug 1207890

Comment 26

[Ian Neal]

Attachment: f) Port bug 1244999

Comment 27

[Ian Neal]

Attachment: g) Port bug 1352982

Comment 28

[Ian Neal]

Attachment: h) Port bug 1380690

Comment 29

[Ian Neal]

Attachment: i) Port bug 862770

Comment 30

[Ian Neal]

Attachment: j) Port bug 1235982

Comment 31

[Ian Neal]

Attachment: k) Port bug 793735

Comment 32

[Ian Neal]

Attachment: l) Port bug 1347360

Comment 33

[Ian Neal]

Attachment: m) Port changes to Info.plist.in

Comment 34

[Ian Neal]

Attachment: n) Tidy up license file insertion

Comment 35

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056381 [details] [diff] [review]
a) Port bug 743280

As discussed on irc. Tested on esr60 so good to go there too.

Comment 36

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056382 [details] [diff] [review]
b) Port bug 748389

As discussed on irc. Tested on esr60 so good to go there too.

Comment 37

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056383 [details] [diff] [review]
c) Port bug 787180

As discussed on irc. Tested on esr60 so good to go there too.

Comment 38

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056384 [details] [diff] [review]
d) Port Bug 910781

As discussed on irc. Tested on esr60 so good to go there too.

Comment 39

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056385 [details] [diff] [review]
e) Port bug 1207890

As discussed on irc. Tested on esr60 so good to go there too.

Comment 40

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056386 [details] [diff] [review]
f) Port bug 1244999

As discussed on irc. Tested on esr60 so good to go there too.

Comment 41

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056387 [details] [diff] [review]
g) Port bug 1352982

As discussed on irc. Tested on esr60 so good to go there too.

Comment 42

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056388 [details] [diff] [review]
h) Port bug 1380690

As discussed on irc. Tested on esr60 so good to go there too.

Comment 43

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056389 [details] [diff] [review]
i) Port bug 862770

As discussed on irc. Tested on esr60 so good to go there too.

Comment 44

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056390 [details] [diff] [review]
j) Port bug 1235982

As discussed on irc. Tested on esr60 so good to go there too.

Comment 45

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056391 [details] [diff] [review]
k) Port bug 793735

As discussed on irc. Tested on esr60 so good to go there too.

Comment 46

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056392 [details] [diff] [review]
l) Port bug 1347360

As discussed on irc. Tested on esr60 so good to go there too.

Comment 47

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056393 [details] [diff] [review]
m) Port changes to Info.plist.in

As discussed on irc. Tested on esr60 so good to go there too.

Comment 48

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9056394 [details] [diff] [review]
n) Tidy up license file insertion

As discussed on irc. Tested on esr60 so good to go there too.

Comment 49

[Frank-Rainer Grahl (:frg)]

Compiled 2.57 Windows, Linux and macOS x64. Tested the Windows and macOS builds and didn't see any problems.

Comment 50

[Stefan [:stefanh]]

Comment on attachment 9056393 [details] [diff] [review]
m) Port changes to Info.plist.in

+	<key>LSFileQuarantineEnabled</key>
+	<true/>

This will cause all files created by SM to be quarantined. It makes sense for the browser, but I'm not sure about the other parts. For example, if I got it right, opening a file created by Composer will cause the OS to display a warning.

Comment 51

[Stefan [:stefanh]]

Comment on attachment 9056388 [details] [diff] [review]
h) Port bug 1380690

Hmm, Thunderbird doesn't have this. What does it do?

Comment 52

[Stefan [:stefanh]]

Comment on attachment 9056381 [details] [diff] [review]
a) Port bug 743280

Not tested, but makes sense (and frg tested it)

Comment 53

[Stefan [:stefanh]]

Comment on attachment 9056382 [details] [diff] [review]
b) Port bug 748389

Not tested, but makes sense (and frg tested it).

Comment 54

[Stefan [:stefanh]]

Comment on attachment 9056387 [details] [diff] [review]
g) Port bug 1352982

Not tested, but makes sense (and frg tested it)

Comment 55

[Stefan [:stefanh]]

Comment on attachment 9056385 [details] [diff] [review]
e) Port bug 1207890

Not tested, but makes sense.

Comment 56

[Ian Neal]

(In reply to Stefan [:stefanh] from comment #51)

Comment on attachment 9056388 [details] [diff] [review]
h) Port bug 1380690

Hmm, Thunderbird doesn't have this. What does it do?

Just puts some extra info in the package for OSX

Comment 57

[Ian Neal]

(In reply to Stefan [:stefanh] from comment #50)

Comment on attachment 9056393 [details] [diff] [review]
m) Port changes to Info.plist.in

• <key>LSFileQuarantineEnabled</key>
• <true/>

This will cause all files created by SM to be quarantined. It makes sense
for the browser, but I'm not sure about the other parts. For example, if I
got it right, opening a file created by Composer will cause the OS to
display a warning.

As far as I can see there is only an exclusion path that sits alongside this setting, not an inclusion path. If it cannot distinguish between stuff that is created locally (e.g. in composer) and stuff that is coming in from the internet (web content and emails) it is probably best we leave this out.

Comment 58

[Stefan [:stefanh]]

Comment on attachment 9056393 [details] [diff] [review]
m) Port changes to Info.plist.in

> (In reply to Stefan [:stefanh] from comment #50)
> > Comment on attachment 9056393 [details] [diff] [review]
> > m) Port changes to Info.plist.in
> > 
> > +	<key>LSFileQuarantineEnabled</key>
> > +	<true/>
> > 
> > This will cause all files created by SM to be quarantined. It makes sense
> > for the browser, but I'm not sure about the other parts. For example, if I
> > got it right, opening a file created by Composer will cause the OS to
> > display a warning.
> 
> As far as I can see there is only an exclusion path that sits alongside this setting, not an inclusion path. If it cannot distinguish between stuff that is created locally (e.g. in composer) and stuff that is coming in from the internet (web content and emails) it is probably best we leave this out.

Yes, f+ if leaving that out. IIRC l decided to not use this (many years ago) for the above reasons.

Comment 59

[Ian Neal]

Attachment: m) Port changes to Info.plist.in

Reviewed LSFileQuarantineEnabled section, carrying forward r/f/a

Comment 60

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/38f4f5cb9abc
Part 1: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/2bb46bd6ed1f
Part 2: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/1232d72e39d1
Part 3: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/215d8ed0ad37
Part 4: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/bea0db75d407
Part 5: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/1d08ace47f9f
Part 6: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/488f5744c3c4
Part 7: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/4b544be36ee0
Part 8: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/fce7da3fbd8e
Part 9: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/9e78d4c03991
Part 10: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/f50798a0397c
Part 11: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/09d459e4a13b
Part 12: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/a16041732d6b
Part 13: Update and tidy suite/app/ build files. r=frg
https://hg.mozilla.org/comm-central/rev/8dca02aa228a
Part 14: Update and tidy suite/app/ build files - Tidy up license file insertion. r=frg

Comment 61

[Frank-Rainer Grahl (:frg)]

Part a to n (1 to 14 but mixed up 13 = n with 14 = m)
https://hg.mozilla.org/releases/comm-esr60/pushloghtml?changeset=8e29ae45df192648bcb7b6beed10ca775bb939ae

Comment 62

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bc622f0bd3ec
Fix part 14: Add dependency on LICENSE_TXT_FILE to libs step. rs=bustage-fix