Closed Bug 1541287 Opened 6 years ago Closed 2 years ago

sumo serving 404 pages in random languages

Categories

(support.mozilla.org :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: aswan, Unassigned)

Details

User Story

STR:
1. Visit this link:
https://support.mozilla.org/1/firefox/82.0a1/Linux/en-US/bogus-page (where "bogus-page" can be anything you like)

EXPECTED RESULTS:
This should give reliably give me a 404 page *in US English*. (Note the "en-US" in the URL)
 
ACTUAL RESULTS:
This gives me a 404 page in a random language (it changes each time I reload).


For comparison, this alternate broken-link (with the locale at the start of the path) **does** reliably give me an error page in US English:
https://support.mozilla.org/en-US/bogus-page

It's specifically the "/1/firefox/version/os/locale/" URLs that have arbitrary-language 404 pages.  This is a common pattern for SuMo links that are in Firefox, so we should handle broken/not-yet-staged versions gracefully.

This page is 404 on sumo:
https://support.mozilla.org/1/firefox/68.0a1/Darwin/en-US/tips-assessing-safety-extension

If I load it repeatedly, I get the 404 page in a variety of different languages.

It should of course serve just what's requested in the Accept-Language header

This should be fixed now. Please re-open if this is not the case.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

This doesn't appear to be fixed. I just loaded the page from comment 0 and after reloading, got a page in a language I didn't recognize...

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

I get page not found.
But where does the the link come from??
And it should ultimately resolve to https://support.mozilla.org/kb/tips-assessing-safety-extension ?

To be clear, the point of this bug isn't about getting the URL from comment 0 to redirect to a valid page, the point is that error pages (for whatever type of error) should be served in an appropriate language.

I ran into this today as well. It looks like:
(1) We use links that start with https://support.mozilla.org/1/ in a lot of places for some reason (e.g. in comment 0, and in our code

(2) We always include the locale in these links (e.g. notice "en-US" in comment 0; and in about:preferences "Privacy" section I see https://support.mozilla.org/1/firefox/82.0a1/Linux/en-US/enhanced-tracking-protection

(3) BUT -- this is the bug -- if you mess up one of these URLs (e.g. add an extra character to the end), or if the URL is still "staging"/reserved (as is the case for a link on about:pioneer), then SuMo gives you a 404 page in a random language. This feels quite broken, given that there's a locale right there in the URL.

[I'm adding some simple/straightforward STR in the User Story.]

User Story: (updated)

(Specifically, I ran into this today at about:pioneer in Nightly, which has a "managing the data you share" support link to https://support.mozilla.org/1/firefox/82.0a1/Linux/en-US/pioneer-managing-account-data , which I believe is intended to eventually have content but does not currently have content. It's fine that its content isn't there yet, but in the meantime I would expect this link to give me a 404 page in US-English, given that the locale is right there in the URL. Instead, it gives me a 404 page in a random language, which adds a second layer of brokenness/sharp-edgedness on top of the (understandable) brokenness from the content being missing for now.)

Hey Daniel & Andrew,

I know it's been a long time since this bug was filled. I'm unable to reproduce this issue (tried using the steps from the user story as well).

Wondering if you are still able to reproduce this issue.

Thanks!

Flags: needinfo?(dholbert)
Flags: needinfo?(andrew.swan)

I am no longer able to reproduce this...

Flags: needinfo?(andrew.swan)

Yeah, I can't repro either (using my URLs from comment 7 and the User Story).

Status: REOPENED → RESOLVED
Closed: 6 years ago2 years ago
Flags: needinfo?(dholbert)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.