Chimera shouldn't add and use a profile in ~/.mozilla

VERIFIED FIXED

Status

Camino Graveyard
Preferences
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Conrad Carlen (not reading bugmail), Assigned: Conrad Carlen (not reading bugmail))

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
This makes a "Chimera" profile show up in the mach-0 profile list and it means
the profile is in an invisible folder. Most unfriendly. Patch coming up.
(Assignee)

Comment 1

16 years ago
Created attachment 89064 [details] [diff] [review]
patch

The patch makes Chimera install its own app dir service provider.
(Assignee)

Comment 2

16 years ago
This needs to do in along with bug 118203 but the Chimera-specific part is here.
Status: NEW → ASSIGNED
Depends on: 118203
(Assignee)

Comment 3

16 years ago
Ignore the whitespace problems - just noticed it and de-tabbed.
Comment on attachment 89064 [details] [diff] [review]
patch

r=pink

let's figure out what we want to call the profile dir name, since we cannot
call it ProjectX and we don't want separate profiles for moz vs. commercial
Attachment #89064 - Flags: review+
comments:

- you set an arbitrary 512 max length on paths, is there any way to remove that
or figure out how long the path is for an FSRef before you convert it to a path?

- how does that 512 relate to PATH_MAX on other platforms, or on darwin?

+  FileInfo fInfo; // Finder flags are in the same place whether we use FileInfo
or FolderInfo
+  ::BlockMoveData(&catalogInfo.finderInfo, &fInfo, sizeof(FileInfo));
+  if ((fInfo.finderFlags & kIsInvisible) != 0) {
+    *_retval = PR_TRUE;
+  }

don't need to copy data just to check a flag

+  // XXX - Because we define DARWIN, we can't use CFURLGetFSRef. This blows.

file a bug for us to turn that off. we really should not be defining DARWIN when
building mozilla. as a workaround, can't you just #undef DARWIN at the top of
the file before including anything else? we do that in widget/src/cocoa all over
the place.

+  // XXX - This should be cut from the API. Would create an evil dependency.

how do the other platforms handle it?

+  // *outIsPackage = ((mCachedCatInfo.dirInfo.ioFlAttrib & kioFlAttribDirMask) &&
+  // (mCachedCatInfo.dirInfo.ioDrUsrWds.frFlags & kHasBundle));

if we're not going to check the bundle flag, we need to check for more than just
.app (.plugin? or any cfm app that's a package that doesn't end in .app, like
mozilla)

with these fixed, r=pink. conrad and i have already discussed them and he's
working on them. just wanted to include them here so any sr (read: smfr) would
know i'd already brought them up.



oops, wrong bug. sorry.

Comment 7

16 years ago
Comment on attachment 89064 [details] [diff] [review]
patch

+#define APP_REGISTRY_NAME		NS_LITERAL_CSTRING("appreg")

Pick a nicer name with the correct extension, and sr=sfraser
Attachment #89064 - Flags: superreview+
(Assignee)

Comment 8

16 years ago
> Pick a nicer name with the correct extension, and sr=sfraser

Thanks. Changed it to be "Application.regs"
(Assignee)

Comment 9

16 years ago
Fixed, caused regresson bug 154815, now that's fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 10

16 years ago
with 07-01 build, verified that profile is now stored in
user/(username)/library/Profile.
Status: RESOLVED → VERIFIED

Comment 11

16 years ago
I get:

/Users/benc/Library/Chimera

Actually, for Mac OS X, I'd prefer something like "~/Library/Profiles", because
I don't think people are going to tolerate "Mozilla" and "Chimera" being in
their paths forever.
You need to log in before you can comment on or make changes to this bug.