154135 - Chimera shouldn't add and use a profile in ~/.mozilla

Status: VERIFIED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Conrad Carlen (not reading bugmail)]

This makes a "Chimera" profile show up in the mach-0 profile list and it means
the profile is in an invisible folder. Most unfriendly. Patch coming up.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch

The patch makes Chimera install its own app dir service provider.

Comment 2

[Conrad Carlen (not reading bugmail)]

This needs to do in along with bug 118203 but the Chimera-specific part is here.

Comment 3

[Conrad Carlen (not reading bugmail)]

Ignore the whitespace problems - just noticed it and de-tabbed.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 89064 [details] [diff] [review]
patch

r=pink

let's figure out what we want to call the profile dir name, since we cannot
call it ProjectX and we don't want separate profiles for moz vs. commercial

Comment 5

[Mike Pinkerton (not reading bugmail)]

comments:

- you set an arbitrary 512 max length on paths, is there any way to remove that
or figure out how long the path is for an FSRef before you convert it to a path?

- how does that 512 relate to PATH_MAX on other platforms, or on darwin?

+  FileInfo fInfo; // Finder flags are in the same place whether we use FileInfo
or FolderInfo
+  ::BlockMoveData(&catalogInfo.finderInfo, &fInfo, sizeof(FileInfo));
+  if ((fInfo.finderFlags & kIsInvisible) != 0) {
+    *_retval = PR_TRUE;
+  }

don't need to copy data just to check a flag

+  // XXX - Because we define DARWIN, we can't use CFURLGetFSRef. This blows.

file a bug for us to turn that off. we really should not be defining DARWIN when
building mozilla. as a workaround, can't you just #undef DARWIN at the top of
the file before including anything else? we do that in widget/src/cocoa all over
the place.

+  // XXX - This should be cut from the API. Would create an evil dependency.

how do the other platforms handle it?

+  // *outIsPackage = ((mCachedCatInfo.dirInfo.ioFlAttrib & kioFlAttribDirMask) &&
+  // (mCachedCatInfo.dirInfo.ioDrUsrWds.frFlags & kHasBundle));

if we're not going to check the bundle flag, we need to check for more than just
.app (.plugin? or any cfm app that's a package that doesn't end in .app, like
mozilla)

with these fixed, r=pink. conrad and i have already discussed them and he's
working on them. just wanted to include them here so any sr (read: smfr) would
know i'd already brought them up.

Comment 6

[Mike Pinkerton (not reading bugmail)]

oops, wrong bug. sorry.

Comment 7

[Simon Fraser [no longer active]]

Comment on attachment 89064 [details] [diff] [review]
patch

+#define APP_REGISTRY_NAME		NS_LITERAL_CSTRING("appreg")

Pick a nicer name with the correct extension, and sr=sfraser

Comment 8

[Conrad Carlen (not reading bugmail)]

> Pick a nicer name with the correct extension, and sr=sfraser

Thanks. Changed it to be "Application.regs"

Comment 9

[Conrad Carlen (not reading bugmail)]

Fixed, caused regresson bug 154815, now that's fixed.

Comment 10

[Winnie Lam]

with 07-01 build, verified that profile is now stored in
user/(username)/library/Profile.

Comment 11

[benc]

I get:

/Users/benc/Library/Chimera

Actually, for Mac OS X, I'd prefer something like "~/Library/Profiles", because
I don't think people are going to tolerate "Mozilla" and "Chimera" being in
their paths forever.