1541409 - hooks_clang_format fails on multiple files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Jan-Erik Rediger [:janerik]]

I recently added hooks_clang_format.py to run as the pre-commit hook on my git checkout of m-c.
However, it seems to have problems when multiple files are stages for the commit:

I get this output:

fatal: pathspec 'browser/base/content/test/about/browser_aboutCertError_telemetry.js browser/base/content/test/siteIdentity/browser_identityPopup_clearSiteData.js [...many more files]' did not match any files

I suspect it is because the files are concatenated into a single space-separated string and then passed to git as one argument.

git expects each file as its own argument though. Guess we should change add_remove_files to take a list instead?

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Interesting. Thanks for reporting that.

Btw, I should probably filter out js files in the hook itself.

Comment 2

[Jan-Erik Rediger [:janerik]]

ah yes, guess clang-format wouldn't need to touch these ever, so making it do less work is a sensible thing to do.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

For now, I am fixing the core issue. I will create a follow up to only format supported files.
To test my change:

sed -i -e "s|#include |#include    |g" dom/presentation/AvailabilityCollection.cpp
sed -i -e "s|#include |#include    |g" dom/presentation/Presentation.cpp
git add dom/presentation/AvailabilityCollection.cpp dom/presentation/Presentation.cpp
git commit -m "foo"

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1541409 - git clang-format hook: add files one by one to avoid an error r?sheehan

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/400fd14b1c83
git clang-format hook: add files one by one to avoid an error r=sheehan

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/400fd14b1c83