1541415 - Write tests to ensure the main search engines use the correct codes in all regions/locales

Status: RESOLVED FIXED

(Firefox :: Search, task)

Description

[Mark Banner (:standard8)]

We need to add some unit tests to ensure that we have the correct codes for the main search engines present in all region/locales.

This should extend the work done in bug 1541210.

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1541415 - Add test to ensure engines send correct code. r?Standard8

Depends on D31545

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b460e6b4e9e2
Add test to ensure engines send correct code. r=Standard8

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b460e6b4e9e2

Comment 4

[Jorg K (CEST = GMT+2)]

You're keeping the TB search engines in mind when tightening your tests?

Looks like you're testing something for specific Google "locales"
https://hg.mozilla.org/mozilla-central/rev/b460e6b4e9e2a54e616e6517d6091dd2a44b8c9d#l8.17

which we don't have:
https://searchfox.org/comm-central/source/mail/components/search/extensions/google

So the test will most likely fail for us now.

Comment 5

[Jorg K (CEST = GMT+2)]

As predicted, the Google, Bing, DDG and Yandex tests all fail since we don't have the partner codes, like MOZSBR or client=firefox-b-1-d. Any suggestions other than just switching off all the tests?

Comment 6

[Dale Harvey (:daleharvey)]

So these tests are specifically testing the configuration, not that the engines work but that they exist in the regions and send the correct codes etc particularly focussing on the ones we have a relationship with.

Since that doesnt apply to Thunderbird, I am not sure there is a downside to turning these tests off, they arent really relevant imo

Comment 7

[Jorg K (CEST = GMT+2)]

Well, I thought the region test was useful for Thunderbird. Other than that, this really should be refactored. You test a browser-specific configuration in a toolkit test. That's not right.

Comment 8

[Mark Banner (:standard8)]

(In reply to Jorg K (GMT+2) from comment #7)

Well, I thought the region test was useful for Thunderbird. Other than that, this really should be refactored. You test a browser-specific configuration in a toolkit test. That's not right.

The intention for us to to use these across Desktop and Android, that's why we put them there in the first place (since our requirements for those are highly similar).

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fbf66e32c2c2