Re-initialization of polling when adding a new client should be improved

RESOLVED FIXED in Firefox 68

Status

()

enhancement
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: leplatrem, Assigned: leplatrem)

Tracking

other
Firefox 68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 months ago

Currently we empty the last ETag
https://searchfox.org/mozilla-central/rev/44a212460990ffffecf50a8e972d3cbde2e7216b/services/settings/remote-settings.js#107-109

But it's used elsewhere (like Megaphone). So this isn't great, since we end up with warnings like:

--DOMWINDOW == 10 (0x7face6b0ec00) [pid = 4608] [serial = 2] [outer = (nil)] [url = about:blank]
console.info: BroadcastService: addListener: adding listener remote-settings/monitor_changes "0" {"moduleURI":"resource://services-settings/remote-settings.js","symbolName":"remoteSettingsBroadcastHandler"}
console.warn: BroadcastService: Versions differ while adding listener for remote-settings/monitor_changes . Got "0" but JSON file says "1554230857384" .

Assignee

Updated

3 months ago
Type: defect → enhancement
Assignee

Comment 1

2 months ago

Improve invalidation of polling when adding new Remote Settings client

Comment 3

2 months ago
Pushed by mleplatre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e05177437976
Improve invalidation of polling when adding new Remote Settings client r=glasserc

Comment 4

2 months ago
bugherder
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Assignee: nobody → mathieu
You need to log in before you can comment on or make changes to this bug.