1541432 - Move browser_keyword* tests from browser/base/content/test/general to browser/components/urlbar

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Mark Banner (:standard8)]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
2. Download and build the Firefox source code: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
   • An artifact build is fine.
   • If you have any problems, please ask on IRC (https://wiki.mozilla.org/Irc) in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Introduction
3. Start working on this bug.
   • Use hg to move the files to the new location: hg mv browser/base/content/test/general/browser_keyword* browser/components/urlbar/tests/browser/
   • References to the tests in the browser/base/content/test/general/browser.ini file should be moved across to the browser/components/urlbar/tests/browser/browser.ini file (please try and follow the filename order in the new ini file).
     • Include any lines following until the next test is listed, but remove the comment lines that start with # DO NOT ADD ...
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #introduction channel on IRC (https://wiki.mozilla.org/Irc) most hours of most days.
4. Build your change with ./mach build and test your change with ./mach mochitest browser/components/urlbar. Also check your changes for adherence to our style guidelines by using ./mach eslint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • Use a commit message such as Bug nnnnn - Move browser_keyword* tests into browser/components/urlbar. r?Standard8
   • Here's the guide: https://developer.mozilla.org/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland our integration branch. Your changes will soon be part of the Firefox code base.
7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Comment 1

[Asra Q [:aqadri]]

Hi Mark, Can I please work on this issue?

Comment 2

[Asra Q [:aqadri]]

Attachment: Bug 1541432: Move browser_keyword* tests from browser/base/content/test/general to browser/components/urlbar. r=Standard8

Comment 3

[Asra Q [:aqadri]]

Attachment: Bug 1541432: Move browser_keyword* tests from browser/base/content/test/general to browser/components/urlbar. r=standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10c226df417e
Move browser_keyword* tests from browser/base/content/test/general to browser/components/urlbar. r=Standard8

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/10c226df417e