1541494 - Stop writing compatibility.ini piecemeal and on the main thread and on startup

Status: NEW

(Toolkit :: Startup and Profile System, task, P3)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1541491 +++

If we decide in 1541491 that we need to keep compatibility.ini, nsAppRunner.cpp's WriteVersion should stop writing it in 20-odd increments, and write the entire (short) file out at once, and off-main-thread, after startup.

Comment 1

[Dave Townsend [:mossop]]

(In reply to :Gijs (he/him) from comment #0)

+++ This bug was initially created as a clone of Bug #1541491 +++

If we decide in 1541491 that we need to keep compatibility.ini, nsAppRunner.cpp's WriteVersion should stop writing it in 20-odd increments, and write the entire (short) file out at once, and off-main-thread, after startup.

If we're writing it off-main-thread then we should probably at least truncate it or something immediately so if the write never succeeds the next run knows that the profile has been modified in some way.

Comment 2

[:Gijs (he/him)]

(In reply to Dave Townsend [:mossop] (he/him) from comment #1)

If we're writing it off-main-thread then we should probably at least truncate it or something immediately so if the write never succeeds the next run knows that the profile has been modified in some way.

We could block shutdown on writing it...

Comment 3

[Dave Townsend [:mossop]]

(In reply to :Gijs (he/him) from comment #2)

(In reply to Dave Townsend [:mossop] (he/him) from comment #1)

If we're writing it off-main-thread then we should probably at least truncate it or something immediately so if the write never succeeds the next run knows that the profile has been modified in some way.

We could block shutdown on writing it...

That's great, unless we crash.