1541500 - [android] Selection within SVG content does not use the correct highlight color

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Jonathan Kew [:jfkthame]]

Selecting text in an SVG document on Android does not use the expected (blue) background color to highlight the selected content; it uses gray, as if the element were inactive.

STR, in Firefox for Android:

1. load https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/reftests/svg/text/simple-selection.svg
2. double-tap on the word "hello" to select it

ER:
The text should be highlighted with a blue background

AR:
The text is highlighted with a gray background

For comparison, try the same thing with the HTML reference file for that testcase, https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/reftests/svg/text/simple-selection.svg

In this case, the text is highlighted with a blue background as expected.

(The test apparently only passes on CI at the moment because (despite the needs-focus annotation in reftest.list) the test and reference images are captured in an inactive state, and so the highlight is gray in both cases.)

Comment 1

[Jonathan Kew [:jfkthame]]

It looks like the problem occurs because the blue selection background on Android is provided by the CSS at https://searchfox.org/mozilla-central/rev/14dc5b7d8a6da1854b2f9f33f1da77a97368cd54/mobile/android/themes/geckoview/content.css#11-14, but this doesn't apply to elements in the svg namespace.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1541500 - Apply Android ::selection styling to SVG as well as HTML content. r=snorp

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae91888401d2
Apply Android ::selection styling to SVG as well as HTML content. r=snorp

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ae91888401d2

Comment 5

[Diana Rus]

Hi, verified with device Sony Xperia Z3(Android 5.1.1) on build Firefox 68.0 build3/mozilla-esr68, on the given page from description, for the SVG page the instead of having the the text selected, a zoom action is present.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.