Closed
Bug 1541513
Opened 5 years ago
Closed 5 years ago
Stop using AutoJSContext in XPConnect
Categories
(Core :: XPConnect, task)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(7 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
Assignee | |
Comment 7•5 years ago
|
||
The change to the second FindTearOff call in XPCWrappedNative::GetNewOrUsed is
fixing a longstanding bug that was introduced in bug 903891 when the sense of
the check was incorrectly reversed. Luckily that code is unreached in
practice, because the two PreCreate hooks we have left never create the wrapper.
|
||
Updated•5 years ago
|
Attachment #9055601 -
Attachment description: Bug 1541513 part 1. Stop using AutoJSContext in the component loader. r=mccr8 → Bug 1541513 part 1. Stop requiring a JSContext for JS_SetAllNonReservedSlotsToUndefined. r=jandem
|
|
Assignee | |
Updated•5 years ago
|
Type: defect → task
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af078caf2797 part 1. Stop requiring a JSContext for JS_SetAllNonReservedSlotsToUndefined. r=jandem https://hg.mozilla.org/integration/autoland/rev/26c882bc26e1 part 2. Stop using AutoJSContext in some simple XPCConvert cases. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/3189597f56ee part 3. Stop using AutoJSContext in NativeInterface2JSObject. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/ff2ab8f83c38 part 4. Stop using AutoJSContext in NativeData2JS. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/92f5dfde163e part 5. Stop using AutoJSContext in XPCWrappedNativeProto. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/95b464081117 part 6. Stop using AutoJSContext in XPCWrappedNativeInfo. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/aa44b9bb3b6a part 7. Stop using AutoJSContext in XPConnect. r=mccr8
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/af078caf2797
https://hg.mozilla.org/mozilla-central/rev/26c882bc26e1
https://hg.mozilla.org/mozilla-central/rev/3189597f56ee
https://hg.mozilla.org/mozilla-central/rev/ff2ab8f83c38
https://hg.mozilla.org/mozilla-central/rev/92f5dfde163e
https://hg.mozilla.org/mozilla-central/rev/95b464081117
https://hg.mozilla.org/mozilla-central/rev/aa44b9bb3b6a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•