Closed Bug 1541546 Opened 1 year ago Closed 1 year ago

Use the rust representation of colors in the style system.

Categories

(Core :: CSS Parsing and Computation, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(3 files)

No description provided.

Also s/Foreground/CurrentColor.

That is, change all uses of StyleComplexColor to just StyleColor.

Depends on D25976

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba71816514eb
Expose colors via cbindgen. r=heycam
https://hg.mozilla.org/integration/autoland/rev/4da6fb98e8f9
Use the rust color representation. r=heycam
https://hg.mozilla.org/integration/autoland/rev/895863144707
Use only the new name for StyleColor. r=heycam

Backed out for causing build bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=238111910&revision=895863144707dd9216fcb26807a22217a5e3eda1

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238111910&repo=autoland&lineNumber=23234

Backout link: https://hg.mozilla.org/integration/autoland/rev/95484a7dc30b364232a5cc905bdfdf4f665d369b

Failure snippet:

[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/style'
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_layout_style2.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/obj-firefox/layout/style -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/layout/base -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/svg -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/html -I/builds/worker/workspace/build/src/dom/xbl -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/image -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/Unified_cpp_layout_style2.o.pp /builds/worker/workspace/build/src/obj-firefox/layout/style/Unified_cpp_layout_style2.cpp
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/layout/style/Unified_cpp_layout_style2.cpp:128:0:
[task 2019-04-04T12:03:52.874Z] 12:03:52 ERROR - /builds/worker/workspace/build/src/layout/style/StyleColor.cpp:50:37: error: specialization of 'template<class RGBA> bool mozilla::StyleGenericColor<RGBA>::MaybeTransparent() const' in different namespace [-fpermissive]
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - bool StyleColor::MaybeTransparent() const {
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - ^~~~~
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - In file included from /builds/worker/workspace/build/src/layout/style/nsStyleConsts.h:17:0,
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/layers/LayersTypes.h:19,
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/BasicEvents.h:12,
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/EventListenerManager.h:10,
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/DOMEventTargetHelper.h:18,
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/MediaQueryList.h:19,
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - from /builds/worker/workspace/build/src/layout/style/MediaQueryList.cpp:9,
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - from /builds/worker/workspace/build/src/obj-firefox/layout/style/Unified_cpp_layout_style2.cpp:2:
[task 2019-04-04T12:03:52.874Z] 12:03:52 ERROR - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ServoStyleConsts.h:3088:8: error: from definition of 'template<class RGBA> bool mozilla::StyleGenericColor<RGBA>::MaybeTransparent() const' [-fpermissive]
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - bool MaybeTransparent() const;
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - ^~~~~~~~~~~~~~~~
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - /builds/worker/workspace/build/src/config/rules.mk:805: recipe for target 'Unified_cpp_layout_style2.o' failed
[task 2019-04-04T12:03:52.874Z] 12:03:52 ERROR - make[4]: *** [Unified_cpp_layout_style2.o] Error 1
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/style'
[task 2019-04-04T12:03:52.874Z] 12:03:52 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2019-04-04T12:03:52.881Z] 12:03:52 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/xul'
[task 2019-04-04T12:03:52.881Z] 12:03:52 INFO - layout/xul/Unified_cpp_layout_xul1.o

Flags: needinfo?(emilio)
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/51298369fb0b
Expose colors via cbindgen. r=heycam
https://hg.mozilla.org/integration/autoland/rev/bab32ba95bcc
Use the rust color representation. r=heycam
https://hg.mozilla.org/integration/autoland/rev/4fedc80c2609
Use only the new name for StyleColor. r=heycam
Flags: needinfo?(emilio)
Type: defect → task
You need to log in before you can comment on or make changes to this bug.