[wpt-sync] Sync PR 16053 - Revert "Reland "Create RTCIceTransport using a webrtc::IceTransportInterface object.""

RESOLVED FIXED in Firefox 68

Status

()

defect
P4
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [wptsync downstream], )

Sync web-platform-tests PR 16053 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16053
Details from upstream follow.

Marina Ciocea <marinaciocea@chromium.org> wrote:

Revert "Reland "Create RTCIceTransport using a webrtc::IceTransportInterface object.""

This reverts commit 161757587a9e4dd8089e4e648cace1575a4bec2d.

Reason for revert: I'm gonna revert this change for now because it surfaces a problem with webrtc::IceTransportInterface object lifetime that leads to crashes (see crbug/945210). Looks like the webrtc IceTransport is cleared by Jsep while the IceTransportAdapterImpl is constructed. So we have to fix the raw pointer access and provide some guarantee that the object is still alive when accessing from blink layer.

Original change's description:

Reland "Create RTCIceTransport using a webrtc::IceTransportInterface object."

This is a reland of dd0f551fcd96d46c6ec2b2a7c543cb2083f1831d

Original change's description:

Create RTCIceTransport using a webrtc::IceTransportInterface object.

Previously, when creating a blink::RTCIceTransport, the corresponding
webrtc::IceTransportInterface object was created by the
IceTransportAdapterImpl. However, in DTLS transport implementation, the
webrtc object is preexisting. Pass the preexisting webrtc object when creating
the blink::RTCIceTransport object in this case.

Bug: 907849
Change-Id: Ia024afc101be830e30f233d6ef1bf39f141227df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520486
Commit-Queue: Marina Ciocea \<marinaciocea@chromium.org>
Reviewed-by: Harald Alvestrand \<hta@chromium.org>
Reviewed-by: Henrik Boström \<hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642487}

Bug: 907849
Change-Id: Ib428f33faae0563d12d246bc971e38f9a66d629a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533896
Commit-Queue: Marina Ciocea \<marinaciocea@chromium.org>
Reviewed-by: Henrik Boström \<hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643321}

TBR=hta@chromium.org,hbos@chromium.org,marinaciocea@chromium.org

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 907849,945078,945210
Change-Id: Ib7c5d0b8156d86e47178b757fac3d53520e56ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538181
Reviewed-by: Marina Ciocea \<marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea \<marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643805}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → WebRTC
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a18a0bbf05bf
[wpt PR 16053] - Revert "Reland "Create RTCIceTransport using a webrtc::IceTransportInterface object."", a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5cac9f65e90
[wpt PR 16053] - Revert "Reland "Create RTCIceTransport using a webrtc::IceTransportInterface object."", a=testonly
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.