DataDirectory lookup should use NumberOfRvaAndSizes field

RESOLVED FIXED in Firefox 67

Status

()

defect
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

Trunk
mozilla68
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox66 disabled, firefox67 fixed, firefox68 fixed)

Details

Attachments

(1 attachment)

I was reviewing the PE spec, and it says that we should do this do determine the number of entries in the DataDirectory; there's no guarantee that the directory is exactly IMAGE_NUMBEROF_DIRECTORY_ENTRIES.

Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7fe70897aab6
Modify PEHeaders to use NumberOfRvaAndSizes as maximum DataDirectory length; r=mhowell
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Aaron, is that something that would be safe and valuable to uplift or should we let it ride the 68 train? Thanks

Flags: needinfo?(aklotz)

Comment on attachment 9055624 [details]
Bug 1541597: Modify PEHeaders to use NumberOfRvaAndSizes as maximum DataDirectory length; r=mhowell!

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Launcher process
  • User impact if declined: Potential crashes when certain third-party DLLs are loaded
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple patch, adds additional sanity checks to existing code.
  • String changes made/needed: None
Flags: needinfo?(aklotz)
Attachment #9055624 - Flags: approval-mozilla-beta?

Comment on attachment 9055624 [details]
Bug 1541597: Modify PEHeaders to use NumberOfRvaAndSizes as maximum DataDirectory length; r=mhowell!

Low risk patch that should improve our stability when certain third-party DLLs are loaded, approved for 67 beta 9, thanks.

Attachment #9055624 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.