1541597 - DataDirectory lookup should use NumberOfRvaAndSizes field

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

I was reviewing the PE spec, and it says that we should do this do determine the number of entries in the DataDirectory; there's no guarantee that the directory is exactly IMAGE_NUMBEROF_DIRECTORY_ENTRIES.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1541597: Modify PEHeaders to use NumberOfRvaAndSizes as maximum DataDirectory length; r=mhowell!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fe70897aab6
Modify PEHeaders to use NumberOfRvaAndSizes as maximum DataDirectory length; r=mhowell

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7fe70897aab6

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

Aaron, is that something that would be safe and valuable to uplift or should we let it ride the 68 train? Thanks

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9055624 [details]
Bug 1541597: Modify PEHeaders to use NumberOfRvaAndSizes as maximum DataDirectory length; r=mhowell!

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Launcher process
• User impact if declined: Potential crashes when certain third-party DLLs are loaded
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple patch, adds additional sanity checks to existing code.
• String changes made/needed: None

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9055624 [details]
Bug 1541597: Modify PEHeaders to use NumberOfRvaAndSizes as maximum DataDirectory length; r=mhowell!

Low risk patch that should improve our stability when certain third-party DLLs are loaded, approved for 67 beta 9, thanks.

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a502516c684a