Closed
Bug 1541609
Opened 5 years ago
Closed 5 years ago
Enforce list of whitelisted packages in API
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox66 wontfix, firefox67 wontfix, firefox68 fixed)
RESOLVED
FIXED
mozilla68
People
(Reporter: agi, Assigned: agi)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
We should enforce that no org.mozilla.gecko classes end up in the API, or otherwise any class from other packages that we don't want our API to depend on.
Apilint 0.1.9 offer this feature, see https://github.com/mozilla-mobile/gradle-apilint/commit/e92729047798aa12c0d0186d3fbed67e3aa747d9
|
Assignee | |
Updated•5 years ago
|
Type: defect → enhancement
|
|
Assignee | |
Comment 1•5 years ago
|
||
apilint 0.1.9 fixes a bug that was causing us to miss some annotation lints.
This commit fixes all of them before we can upgrade.
Depends on D26028
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D26029
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac53565c0c69 [geckoview] Add missing nullability annotations. r=esawin https://hg.mozilla.org/integration/autoland/rev/f9a157cbe246 [geckoview] Enforce packages in API. r=snorp,esawin
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ac53565c0c69
https://hg.mozilla.org/mozilla-central/rev/f9a157cbe246
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Updated•5 years ago
|
status-firefox66:
--- → wontfix
status-firefox67:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•