1541647 - With QuantumBar enabled, the Form History Control add-on doesn't work

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Eric Shepherd [:sheppy]]

With quantum bar enabled, the Form History Control add-on has problems. The main thing I see is this:

When I want to recover form content, if I go to open the main history window in FHC by either of the following means:

• Choosing Tools->Form History Control (II)->Manage History
• Clicking the page action icon for FHC and then Manage History in the resulting popup

I get an empty window instead of a window with the FHC history information in it, and see the following messages in Browse Console:

19:23:26.873 TypeError: this.input.inputField is undefined UrlbarEventBufferer.jsm:61:5
    UrlbarEventBufferer resource:///modules/UrlbarEventBufferer.jsm:61
    UrlbarInput resource:///modules/UrlbarInput.jsm:143
    get urlbar chrome://browser/content/browser.js:207
    <anonymous> chrome://browser/content/browser.js:192
    get resource://gre/modules/XPCOMUtils.jsm:129
    _setURLBarPlaceholder chrome://browser/content/browser.js:4139
    initPlaceHolder chrome://browser/content/browser.js:4072
    onDOMContentLoaded chrome://browser/content/browser.js:1426
    onDOMContentLoaded self-hosted:984
19:23:26.894 TypeError: gURLBar is undefined browser.js:1497:7
    onLoad chrome://browser/content/browser.js:1497
    onLoad self-hosted:984

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Thanks for the report, we must look into this.

Comment 2

[Mark Banner (:standard8)]

I just took a brief look.

• The extension is using the browser.window.create API, creating a window with type="popup".
• That calls through to here where we're being created without a toolbar.
• The urlbar element is present, but is not visible.
• Looks like we need to do something with window.toolbar.visible
• There's already something that for some reason sets it to read-only when dealing with popups.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1541647 - Avoid rebinding the urlbar on startup if Quantum Bar is enabled. r=Standard8

Applying the attribute early enough allows us to avoid rebinding the urlbar,
plus a few checks to ensure "popup" windows, without a visible toolbar, work
properly.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2313dfe51d09
Avoid rebinding the urlbar on startup if Quantum Bar is enabled. r=Standard8

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2313dfe51d09