Closed Bug 1541689 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16156 - [css-flexbox] Correctly calculate min-height with justify-content

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16156 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16156
Details from upstream follow.

Christian Biesinger <cbiesinger@chromium.org> wrote:

[css-flexbox] Correctly calculate min-height with justify-content

Spacing added by justification is not meaninfully part of the
intrinsic block size of an item; remove it.

This is especially problematic with percentage sizes, because
with height: 100% and justify-content: flex-end we would
position any flex items at the end and calculate a minimum
size based on the 100%, even though we ought to ignore percentages.

R=dgrogan@chromium.org, eae@chromium.org

Bug: 945214
Change-Id: If4e271df5e550807632d30e5dd1c2b3068d45313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546002
Commit-Queue: Emil A Eklund \<eae@chromium.org>
Reviewed-by: David Grogan \<dgrogan@chromium.org>
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Auto-Submit: Christian Biesinger \<cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646178}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecf6b78ec6e7
[wpt PR 16156] - [css-flexbox] Correctly calculate min-height with justify-content, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ecf6b78ec6e7

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Whiteboard: [wptsync downstream error] → [wptsync downstream]
You need to log in before you can comment on or make changes to this bug.