Closed Bug 1541698 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16159 - [css-text] Consider former breaking opportunities before breaking a word

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16159 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16159
Details from upstream follow.

Javier Fernandez <jfernandez@igalia.com> wrote:

[css-text] Consider former breaking opportunities before breaking a word

When using the break-spaces+break-word combination, there are breaking
opportunities before the first whitespace after a word. However, these
should be avoided if there are previous soft-breaking opportunities in
the line.

We were only considering single leading whitespaces as one of this
former breaking opportunities, which leads to wrong line-breaking
behaviors like the one described in the bug.

With this change we try to generalize the pattern of using one of this
former breaking opportunities, but maximizing the line's length.

Bug: 905315
Change-Id: I289e44277a3953290f865efb28e3c83deb31fa03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546098
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Commit-Queue: Javier Fernandez \<jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#646230}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0f6b11a56a7
[wpt PR 16159] - [css-text] Consider former breaking opportunities before breaking a word, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c0f6b11a56a7

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.