1541726 - Clicking on pin all makes the pinboard disappear

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Andreea Pavel [:apavel]]

If I need to pin all failures on a push, the first time I press the pin all button the pinboard disappears and I always need to push it a second time to see the failures I pinned and classify them.

I'm using Nightly.

Comment 1

[Andreea Pavel [:apavel]]

Also, clicking on the X to close the pinboard does not work. No errors displayed in the console.

Comment 2

[Cameron Dawson [:camd]]

I'll try to get to this shortly.

Comment 3

[Cameron Dawson [:camd]]

We have a policy to not close the details panel+pinboard when there are pinned jobs. But we should throw up a message to that effect so it's clear. Even better might be to give you the option to clear the pinboard and close anyway.

To reproduce the first part, you must have a job selected in one push with the empty pinboard showing. Then click the pin all button in a DIFFERENT push. This pins the jobs, but leaves no job selected, so the pinboard and job details panel closes.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4860

Comment 5

[Andreea Pavel [:apavel]]

Thanks for looking into this so fast Cameron. I tested and can no longer reproduce the first issue.

Regarding the second, I did not know that, but it works as you have described.