1541811 - Cannot sign in on Nightly updated from Google Play

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Settings and Preferences, defect, P1)

Description

[miralobontiu]

Attachment: 2019_04_04_11_15_21.mp4

Devices:

• OnePlus 5T (Android 9.0);
• Samsung Galaxy Note 8 (Android 9.0);
• Sony Xperia Z5 (Android 7);

Build:

• Nightly 68.0a1 (2019-04-03);

Steps to reproduce:

1. Make sure your internet is on.
2. Update Nightly from Google Play.
3. Go to Nightly and sign in to your account.

Expected result:
The user should be able to sign in.

Actual result:
"No internet connection page" is displayed.

Notes:
Not reproducible on Huawei P9 Lite (Android 6.0), and Samsung Galaxy S8 (Android 9).
If Nightly is installed from Google Play, the issue is no longer reproducible.
Please see attached video and logcat.

Comment 1

[miralobontiu]

Attachment: logcat

Comment 2

[Marcia Knous [:marcia]]

Discussed during triage, will try to investigate cause.

Comment 3

[miralobontiu]

Hi,

Found a regression range:
Last good revision: af3e08c3b74522f184719a3c61ce1ff1bb73b161
First bad revision: 596886805d4ea444c892651be2939360be3561df

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=af3e08c3b74522f184719a3c61ce1ff1bb73b161&tochange=596886805d4ea444c892651be2939360be3561df

Device: Sony Xperia Z5 (Android 7.0)

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to miralobontiu from comment #3)

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=af3e08c3b74522f184719a3c61ce1ff1bb73b161&tochange=596886805d4ea444c892651be2939360be3561df

Thyla, JC Jones recently updated NSS 3.44 (bug 1539227), but he's out on parental leave now. Is there another security engineer that can say whether this NSS update might have caused these Android network connection problems?

Comment 5

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

This bug is a serious regression in Fennec 68.

Comment 6

[Thyla van der Merwe]

Hi Chris,

I'm going to ask Kevin Jacobs to take a look (and to consult Dana Keeler if necessary).

Comment 7

[Kevin Jacobs [:kjacobs]]

I was able to reproduce similar, intermittent behavior on on my LG G6 running Android 8.0. Starting with 2019-03-27-04-45-26, if I tap Menu > Settings > Sign in, I see the "Not Connected" page flash briefly, then it recovers (without interaction) and I see the login page. This seems to happen ~70% of the time (in the other 30% it loads correctly).

I'm attaching the latest nightly with NSS 3.44 backed out, where I'm still seeing this behavior.

@miralobontiu, could you please test the attached version and let us know if it exhibits the same behavior? Thanks!

Comment 8

[Kevin Jacobs [:kjacobs]]

Edit: apk is too large to attach. Available here

(In reply to Kevin Jacobs [:kjacobs] from comment #7)

I was able to reproduce similar, intermittent behavior on on my LG G6 running Android 8.0. Starting with 2019-03-27-04-45-26, if I tap Menu > Settings > Sign in, I see the "Not Connected" page flash briefly, then it recovers (without interaction) and I see the login page. This seems to happen ~70% of the time (in the other 30% it loads correctly).

I'm attaching the latest nightly with NSS 3.44 backed out, where I'm still seeing this behavior.

@miralobontiu, could you please test the attached version and let us know if it exhibits the same behavior? Thanks!

Comment 9

[miralobontiu]

Hi Kevin,

I tested with Nightly from Comment 8, on Sony Xperia Z5 (Android 7.0), and I reproduce the same behavior as in Comment 7, the "Not connected" page flashes briefly, but the Sign in page recovers without interaction.
I have to mention that when looking for the regression range, I encountered the same behavior, the "Not connected" page only flashed briefly. Sorry That I did not mention it.

Please let me know if there is anything else I can do.
Thanks!

Comment 10

[Kevin Jacobs [:kjacobs]]

No problem and thank you for the update. Would you be able to try any "official" nightly from 2019-04-18 and let us know if you see the same behavior as with the custom build?

My feeling is that this is likely not NSS (since I see the same issue regardless of NSS version), but I want to make sure you concur, since only you have been able to produce the "blocking" behavior shown in the video.

Comment 11

[miralobontiu]

Sure!
Tested with Sony Xperia Z5 (Android 7.0) on the latest Nightly 68.0a1 (2019-04-19), from Play Store, and the "No internet" page flashes briefly.

Comment 12

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

It would be nice to get a regression range down to the actual changeset that introduced this, since it's not clear that NSS is the issue.

Comment 13

[Chris Peterson [:cpeterson]]

Thanks for testing, Kevin. Suspecting the NSS update in the original regression range (comment 3) was just a hunch.

Andrea, your Content-length fix for wasm cache bug 1487113 touched some HTTP code. Do you think it could have caused these intermittent network connection problems when trying to log into Google Play on Fennec?

Comment 14

[Petru-Mugurel Lingurar [:petru]]

I think bug 1541354 is also related and might help to pinpoint the issue.

Comment 15

[Eliza Balazs]

Hi!

I tested this on the latest version of Nightly 68.0a1 (2019-04-23) with Sony Xperia Z5 (Android 7.0) and I found a regression for this issue:

Last good revision: 06f0c5e35c3ab64490bcdfcb25f7ac6ff531ba5e (2019-03-03)
First bad revision: fd67a4332060ea5389d448b3453ea23064e50b5e (2019-03-04)

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=06f0c5e35c3ab64490bcdfcb25f7ac6ff531ba5e&tochange=fd67a4332060ea5389d448b3453ea23064e50b5e

Thanks!

Comment 16

[Chris Peterson [:cpeterson]]

snorp is investigating these connection errors in bug 1546361.

Comment 17

[Marcia Knous [:marcia]]

Hello Mirabela - Now that the fix has landed, can you see if you still reproduce the issue you were seeing? Thanks in advance.

Comment 18

[miralobontiu]

Attachment: Sony_2019_05_09.mp4

Hi Marcia,

I wasn't able to reproduce the glitch on OnePlus 5T (Android 9.0) and Samsung Galaxy Note 8 (Android 9.0), but on Sony Xperia Z5 (Android 7) it is still reproducible.
Tested on the latest Nightly 68.0a1 (2019-05-08).
Please see the attached short video with the behavior on the Sony device.

So, the issue is not reproducing anymore, the user is now able to sign in, therefore I will close this issue as WORKSFORME. Because of the glitch, I have filed a new bug 1550413.

Thank you!