Implement a gradle plugin for Glean
Categories
(Data Platform and Tools :: Glean: SDK, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: Dexter, Assigned: mdroettboom)
References
Details
(Whiteboard: [telemetry:glean-rs:m8])
Attachments
(1 file)
When using gradle's "offline" mode, building products using glean fails with this error:
FAILURE: Build failed with an exception.
- Where:
Build file '/Users/XXX/src/reference-browser/app/build.gradle' line: 261
- What went wrong:
A problem occurred evaluating project ':app'.
Could not get resource 'https://github.com/mozilla-mobile/android-components/raw/master/components/service/glean/scripts/sdk_generator.gradle'.
Could not HEAD 'https://github.com/mozilla-mobile/android-components/raw/master/components/service/glean/scripts/sdk_generator.gradle'.
> github.com: nodename nor servname provided, or not known
| Reporter | ||
Updated•7 years ago
|
| Reporter | ||
Updated•7 years ago
|
| Reporter | ||
Updated•6 years ago
|
Updated•6 years ago
|
| Reporter | ||
Updated•6 years ago
|
| Assignee | ||
Updated•6 years ago
|
| Reporter | ||
Updated•6 years ago
|
| Assignee | ||
Updated•6 years ago
|
| Assignee | ||
Comment 3•6 years ago
|
||
Some questions as I come back to this work:
-
I see that Fenix now has both an android components version and a
mozilla-gleanversion, which I presume must be kept in sync. We can make gradle plugin releases in tandem with glean-core releases, so we can use the samemozilla-gleanversion number for both glean-core and the gradle plugin. However, what happens if android-components and mozilla-glean are not a matched pair (which doesn't necessarily mean the same version number...)? -
I'm not aware of any projects linking to the
sdk_generator.gradlefile in themozilla/gleanrepo (only the one in android-components). I think it makes sense to keep it like that -- let's migrate all the projects from thesdk_generator.gradlein a-c to the plugin inmozilla/gleanin one step. Agree?
| Assignee | ||
Comment 4•6 years ago
|
||
Agree, but this Android stuff and what repos to pull in where seems like :dexter-territory.
| Reporter | ||
Comment 6•6 years ago
|
||
(In reply to Michael Droettboom [:mdroettboom] from comment #3)
Some questions as I come back to this work:
- I see that Fenix now has both an android components version and a
mozilla-gleanversion, which I presume must be kept in sync.
Yes, bug 1588098 tracks the work to address that.
We can make gradle plugin releases in tandem with glean-core releases, so we can use the same
mozilla-gleanversion number for both glean-core and the gradle plugin. However, what happens if android-components and mozilla-glean are not a matched pair (which doesn't necessarily mean the same version number...)?
Yes, this is a good potential solution! As long as there's no mismatch between the version of mozilla-glean used in a-c and the one that the gradle-plugin makes the product use, we should be fine. Otherwise... we'll potentially crash in tests :)
- I'm not aware of any projects linking to the
sdk_generator.gradlefile in themozilla/gleanrepo (only the one in android-components). I think it makes sense to keep it like that -- let's migrate all the projects from thesdk_generator.gradlein a-c to the plugin inmozilla/gleanin one step. Agree?
Yes, I agree :)
| Assignee | ||
Comment 7•6 years ago
|
||
It feels really good to close this one.
Description
•