1541873 - Perma dom/workers/test/test_worker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface BigInt64Array to all webpages as a property on the worker? - when Gecko 68 merges to Beta on 2019-05-06

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Oana Pop-Rus]

[Tracking Requested - why for this release]:

Central as beta simulation

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=d71d7b6e68ea9dbc465c9da13913c331c22dad4c&selectedJob=238129833

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238129833&repo=try&lineNumber=2824

[task 2019-04-04T12:58:19.219Z] 12:58:19 INFO - TEST-START | dom/workers/test/test_worker_interfaces.html
[task 2019-04-04T12:58:20.479Z] 12:58:20 INFO - TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface BigInt64Array to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-04T12:58:20.480Z] 12:58:20 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-04-04T12:58:20.480Z] 12:58:20 INFO - workerTestExec/worker.onmessage@dom/workers/test/worker_driver.js:36:7
[task 2019-04-04T12:58:20.481Z] 12:58:20 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-04T12:58:20.482Z] 12:58:20 INFO - TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface BigUint64Array to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-04T12:58:20.482Z] 12:58:20 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-04-04T12:58:20.482Z] 12:58:20 INFO - workerTestExec/worker.onmessage@dom/workers/test/worker_driver.js:36:7
[task 2019-04-04T12:58:20.482Z] 12:58:20 INFO - GECKO(1068) | OK: true => true: If this is failing: DANGER, are you sure you want to expose the new interface DOMStringList to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-04T12:58:20.482Z] 12:58:20 INFO - GECKO(1068) | OK: true => true: If this is failing: DANGER, are you sure you want to expose the new interface Directory to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-04T12:58:20.483Z] 12:58:20 INFO - GECKO(1068) | OK: true => true: If this is failing: DANGER, are you sure you want to expose the new interface ErrorEvent to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-04T12:58:20.483Z] 12:58:20 INFO - TEST-PASS | dom/workers/test/test_worker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface Proxy to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

Comment 1

[Robin Templeton [:terpri]]

Attempting to reproduce. Looks like GlobalObject::skipDeselectedConstructor is missing some cases to skip these constructors in non-nightly builds

Comment 2

[Robin Templeton [:terpri]]

Attachment: Conditionally disable Big(U)Int64Array constructors.

Comment 3

[Andreea Pavel [:apavel]]

Robin can this be landed?

Comment 4

[Robin Templeton [:terpri]]

(In reply to Andreea Pavel [:apavel] from comment #3)

Robin can this be landed?

Yes, this is ready to land

Comment 5

[Andreea Pavel [:apavel]]

Importing the patch makes the failures disappear on beta sims:

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=5de631f349bb6f4c5461a825d4ffba4c54ae8f34&searchStr=os%2Cx%2C10.10%2Cdebug%2Cmochitests%2Cwith%2Ce10s%2Ctest-macosx64%2Fdebug-mochitest-e10s-4%2Cm-e10s%284%29&selectedJob=238573810

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57c5d5e19c71
Conditionally disable Big(U)Int64Array constructors. r=jwalden

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/57c5d5e19c71

Comment 8

[Intermittent Failures Robot]

4 failures in 2843 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 4

Platform breakdown:

• osx-10-10-shippable: 2
• macosx64-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1541873&startday=2019-04-01&endday=2019-04-07&tree=all

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in latest late beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=fec4db10fa6d3b503602ae3ec6a07c5a82601111