Closed Bug 1541956 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16243 - Use pre-resolved resource in SVGPatternElement::ReferencedElement

Categories

(Core :: SVG, defect, P4)

Product:
Core
Component:
SVG
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16243 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16243
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Use pre-resolved resource in SVGPatternElement::ReferencedElement

SVGPatternElement::BuildPendingResource() resolves a resource reference
for 'href' on the \<pattern> element using the TreeScope-based "resource
store". SVGPatternElement::ReferencedElement() (re-)resolves the same
reference on its own. Because of this inconsistency we could end up
having a reference to a LayoutObject in the associated SVGResources
object, but not have hooked up a client reference for the (originating)
\<pattern> element.

Use the SVGResource to resolve the target element in ReferencedElement()
too so that there's only one source of truth.

Bug: 949015
Change-Id: I001c4f9260bdc4599843cd53833b749fd320daa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550426
Reviewed-by: Stephen Chenney \<schenney@chromium.org>
Commit-Queue: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#647295}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → SVG
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c10ac90e30e5
[wpt PR 16243] - Use pre-resolved resource in SVGPatternElement::ReferencedElement, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c10ac90e30e5

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.